-
Notifications
You must be signed in to change notification settings - Fork 97
add Stabilizing f16 goal
#509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
folkertdev
wants to merge
4
commits into
rust-lang:main
Choose a base branch
from
folkertdev:stabilize-f16
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+49
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,49 @@ | ||||||
| # Stabilizing `f16` | ||||||
|
|
||||||
| | Metadata | | | ||||||
| | :--------------- | -------------------------------------------------------------------------------- | | ||||||
| | Point of contact | @folkertdev | | ||||||
| | Status | Proposed | | ||||||
| | Tracking issue | | | ||||||
| | Other tracking issues | https://github.com/rust-lang/rust/issues/116909 | | ||||||
| | Zulip channel | N/A | | ||||||
folkertdev marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| | Stabilization | true | | ||||||
|
|
||||||
| ## Summary | ||||||
|
|
||||||
| In recent years we've seen increasing hardware support for the `f16` and `f128` float types. Especially for `f16` support was originally motivated by machine learning/AI, but these types have since also found applications in other domains like graphics and physics simulations. | ||||||
|
|
||||||
| With LLVM 22, the remaining blockers in the backends have been cleared for `f16`, and therefore stabilizing this type in 2026 is realistic. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. mostly cleared 🙃 |
||||||
|
|
||||||
| ## Motivation | ||||||
|
|
||||||
| ### The status quo | ||||||
|
|
||||||
| The `f16` and `f128` are unstable. Their implementations are mostly complete, with some missing const support. For `f128` there are still some serious ABI issues that require fixes in LLVM. For `f16` LLVM 22 has the support we need. | ||||||
|
|
||||||
| ### What we propose to do about it | ||||||
|
|
||||||
| We will stabilize `f16`, and push `f128` as far as we can. There is not much to design at this point. | ||||||
|
|
||||||
| ### Work items over the next year | ||||||
|
|
||||||
| | Task | Owner(s) | Notes | | ||||||
| | ----------- | -------- | ----- | | ||||||
| | complete support in const-eval/miri | @folkertdev | | | ||||||
| | improve support in `rustc_codegen_gcc` | @folkertdev | | | ||||||
| | remove `cfg(target_has_reliable_f16)` | @folkertdev, @tgross35 | | | ||||||
| | write the stabilization report | @folkertdev, @tgross35 | | | ||||||
|
|
||||||
| ## Team asks | ||||||
|
|
||||||
| With @tgross35 as the dedicated reviewer, the asks of the teams are limited. | ||||||
|
|
||||||
| | Team | Support level | Notes | | ||||||
| | ---------- | ------------- | --------------------------------------- | | ||||||
| | [compiler] | small | | | ||||||
| | [libs] | small | | | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Since this is a stabilization. |
||||||
| | [lang] | small | this might be medium? We don't need anything special, but occasionally being fast-tracked would be nice | | ||||||
|
|
||||||
| ## Frequently asked questions | ||||||
|
|
||||||
| ### What do I do with this space? | ||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.