Update manually drop attr project goal as per discussion #517
+34
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadrieril
reviewed
Feb 4, 2026
|
|
||
| #### Proposal 2: Add a `drop_in_place` method to the `Drop` trait | ||
|
|
||
| Add a `drop_in_place` method to the `Drop` trait, which is called by the compiler when a type is dropped. |
Member
There was a problem hiding this comment.
Suggested change
| Add a `drop_in_place` method to the `Drop` trait, which is called by the compiler when a type is dropped. | |
| Add a `drop_in_place` method to the `Destruct` trait, which is called by the compiler instead of the normal drop glue when a type is dropped. |
Member
Author
There was a problem hiding this comment.
I'll hold out for the design discussion here, and then update this accordingly :)
There was a problem hiding this comment.
I think my biggest reservation is whether drop_in_place lives on the Drop trait or the Destruct trait. But I also don't think that needs to be bikeshed at the proposal stage and can be a topic for design once we're putting together an RFC.
Which is to say I am good with the proposal as is, but cautiously.
Nadrieril
reviewed
Feb 4, 2026
Nadrieril
reviewed
Feb 4, 2026
Co-authored-by: Nadrieril <Nadrieril@users.noreply.github.com>
Co-authored-by: Nadrieril <Nadrieril@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
manually-drop-attrproject goal as per the discussion at #project-goals/2026-workshop > Info regarding Experiment for #[manually_drop] project goal[#project-goals/2026-workshop > Info regarding Experiment for #[manually_drop] project goal](https://rust-lang.zulipchat.com/#narrow/channel/546987-project-goals.2F2026-workshop/topic/Info.20regarding.20Experiment.20for.20.23.5Bmanually_drop.5D.20project.20goal/with/572016060)
cc: @Nadrieril
Rendered