Convert to inline diagnostics in `rustc_ty_utils` #152065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

JonathanBrouwer wants to merge 1 commit into rust-lang:main from JonathanBrouwer:convert_ty_utils

+38 −102

Contributor

JonathanBrouwer commented Feb 3, 2026

r? @jdonszelmann


          Convert to inline diagnostics in rustc_ty_utils

590fa1e

rustbot assigned jdonszelmann

rustbot added S-waiting-on-review T-compiler labels

JonathanBrouwer mentioned this pull request

Tracking issue for MCP 959: Remove the fluent files #151366

Open

5 tasks

Collaborator

rust-log-analyzer commented Feb 3, 2026

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

REPOSITORY                                   TAG       IMAGE ID       CREATED      SIZE
ghcr.io/dependabot/dependabot-updater-core   latest    bcec0b4e062b   8 days ago   783MB
=> Removing docker images...
Deleted Images:
untagged: ghcr.io/dependabot/dependabot-updater-core:latest
untagged: ghcr.io/dependabot/dependabot-updater-core@sha256:b662be51f7b8ef7e2c8464428f14e49cb79c36aa9afb7ecb9221dfe0f507050c
deleted: sha256:bcec0b4e062b5ffe11cc1c2729558c0cd96621c0271ab5e97ff3a56e0c25045a
deleted: sha256:64e147d5e54d9be8b8aa322e511cda02296eda4b8b8d063c6a314833aca50e29
deleted: sha256:5cba409bb463f4e7fa1a19f695450170422582c1bc7c0e934d893b4e5f558bc6
deleted: sha256:cddc6ebd344b0111eaab170ead1dfda24acdfe865ed8a12599a34d338fa8e28b
deleted: sha256:2412c3f334d79134573cd45e657fb6cc0abd75bef3881458b0d498d936545c8d
---
tests/ui/drop_non_drop.rs ... ok
tests/ui/duplicate_underscore_argument.rs ... ok
tests/ui/double_parens.rs ... ok
tests/ui/duplicated_attributes.rs ... ok
tests/ui/duration_suboptimal_units_days_weeks.rs ... ok
tests/ui/duration_suboptimal_units.rs ... ok
tests/ui/duration_suboptimal_units_days_weeks.fixed ... ok
tests/ui/duration_subsec.rs ... ok
tests/ui/duration_suboptimal_units.fixed ... ok
tests/ui/double_parens.fixed ... ok
tests/ui/duration_subsec.fixed ... ok
tests/ui/else_if_without_else.rs ... ok
---
...............................................    (147/147)

======== tests/rustdoc-gui/globals.goml ========

[ERROR] line 14: Error: The window properties still all match: for command `wait-for-window-property-false: {"searchIndex": null}`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/index.html?search=Foo>

======== tests/rustdoc-gui/search-result-display.goml ========

[WARNING] line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

Contributor Author

JonathanBrouwer commented Feb 3, 2026

Spurious, will reopen PR to retrigger ci

JonathanBrouwer closed this

rustbot removed the S-waiting-on-review label

JonathanBrouwer reopened this

rustbot added the S-waiting-on-review label

Member

lqd commented Feb 4, 2026

Stealing this to help Jonathan and Jana.

r? me @bors r+ rollup

Contributor

rust-bors bot commented Feb 4, 2026

📌 Commit 590fa1e has been approved by lqd

It is now in the queue for this repository.

rustbot assigned lqd

rust-bors bot added the S-waiting-on-bors label

rustbot unassigned jdonszelmann

rust-bors bot removed the S-waiting-on-review label

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request


          Rollup merge of rust-lang#152065 - JonathanBrouwer:convert_ty_utils, …

458b0f7

…r=lqd

Convert to inline diagnostics in `rustc_ty_utils`

For rust-lang#151366

r? @jdonszelmann

JonathanBrouwer mentioned this pull request

Rollup of 9 pull requests #152093

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request


          Rollup merge of rust-lang#152065 - JonathanBrouwer:convert_ty_utils, …

a965a60

…r=lqd

Convert to inline diagnostics in `rustc_ty_utils`

For rust-lang#151366

r? @jdonszelmann

JonathanBrouwer mentioned this pull request

Rollup of 8 pull requests #152094

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request


          Rollup merge of rust-lang#152065 - JonathanBrouwer:convert_ty_utils, …

e999970

…r=lqd

Convert to inline diagnostics in `rustc_ty_utils`

For rust-lang#151366

r? @jdonszelmann

JonathanBrouwer mentioned this pull request

Rollup of 11 pull requests #152099

Closed

rust-bors bot pushed a commit that referenced this pull request


          Auto merge of #152099 - JonathanBrouwer:rollup-FYyOGkz, r=JonathanBro…

46c8c2f

…uwer

Rollup of 11 pull requests

Successful merges:

 - #150605 (skip codegen for intrinsics with big fallback bodies if backend does not need them)
 - #150992 (link modifier `export-symbols`: export all global symbols from selected uptream c static libraries)
 - #151534 (target: fix destabilising target-spec-json)
 - #152088 (rustbook/README.md: add missing `)`)
 - #151526 (Fix autodiff codegen tests)
 - #151810 (citool: report debuginfo test statistics)
 - #152065 (Convert to inline diagnostics in `rustc_ty_utils`)
 - #152068 (Convert to inline diagnostics in `rustc_resolve`)
 - #152070 (Convert to inline diagnostics in `rustc_pattern_analysis`)
 - #152072 (Convert to inline diagnostics in `rustc_monomorphize`)
 - #152083 (Fix set_times_nofollow for directory on windows)

Failed merges:

 - #152069 (Convert to inline diagnostics in `rustc_privacy`)

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request


          Rollup merge of rust-lang#152065 - JonathanBrouwer:convert_ty_utils, …

19edc5e

…r=lqd

Convert to inline diagnostics in `rustc_ty_utils`

For rust-lang#151366

r? @jdonszelmann

JonathanBrouwer mentioned this pull request

Rollup of 10 pull requests #152100

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request


          Rollup merge of rust-lang#152065 - JonathanBrouwer:convert_ty_utils, …

…r=lqd

Convert to inline diagnostics in `rustc_ty_utils`

For rust-lang#151366

r? @jdonszelmann

JonathanBrouwer mentioned this pull request

Rollup of 10 pull requests #152101

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request


          Rollup merge of rust-lang#152065 - JonathanBrouwer:convert_ty_utils, …

8e361cf

…r=lqd

Convert to inline diagnostics in `rustc_ty_utils`

For rust-lang#151366

r? @jdonszelmann

JonathanBrouwer mentioned this pull request

Rollup of 12 pull requests #152104

Open

rust-bors bot pushed a commit that referenced this pull request


          Auto merge of #152104 - JonathanBrouwer:rollup-N93TdHm, r=JonathanBro…

8bccf12

…uwer

Rollup of 12 pull requests

Successful merges:

 - #150992 (link modifier `export-symbols`: export all global symbols from selected uptream c static libraries)
 - #151534 (target: fix destabilising target-spec-json)
 - #152088 (rustbook/README.md: add missing `)`)
 - #151526 (Fix autodiff codegen tests)
 - #151810 (citool: report debuginfo test statistics)
 - #151952 (Revert doc attribute parsing errors to future warnings)
 - #152065 (Convert to inline diagnostics in `rustc_ty_utils`)
 - #152066 (Convert to inline diagnostics in `rustc_session`)
 - #152069 (Convert to inline diagnostics in `rustc_privacy`)
 - #152072 (Convert to inline diagnostics in `rustc_monomorphize`)
 - #152083 (Fix set_times_nofollow for directory on windows)
 - #152102 (Convert to inline diagnostics in all codegen backends)

Failed merges:

 - #152068 (Convert to inline diagnostics in `rustc_resolve`)
 - #152070 (Convert to inline diagnostics in `rustc_pattern_analysis`)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors T-compiler