Skip to content

Implement stdio FD constants #152071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hanna-kruppe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement stdio FD constants #152071

hanna-kruppe wants to merge 1 commit into from
+58 −0

Conversation

@hanna-kruppe
Copy link
Contributor

@hanna-kruppe hanna-kruppe commented Feb 3, 2026 •
edited by rustbot
Loading

Tracking issue: #150836

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 3, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 3, 2026

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@hanna-kruppe hanna-kruppe mentioned this pull request Feb 3, 2026
Open
4 tasks
ChrisDenton
ChrisDenton reviewed Feb 4, 2026
View reviewed changes
library/std/src/os/fd/stdio.rs
/// whenever possible. However, there are situations where touching the `std::io` handles (or most
/// other parts of the standard library) risks deadlocks or other subtle bugs. For example:
///
/// - Global allocators must be careful to [avoid reentrancy][global-alloc-reentrancy], and the
Copy link
Member

@ChrisDenton ChrisDenton Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be moved to a new section in the BorrowedFd docs rather than being on STDERR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisDenton ChrisDenton ChrisDenton left review comments

Assignees

@ChrisDenton ChrisDenton

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hanna-kruppe @rustbot @ChrisDenton