Skip to content

compiletest: -Zunstable-options for json targets#152236

Open
davidtwco wants to merge 1 commit intorust-lang:mainfrom
davidtwco:compiletest-destabilise-custom-targets
Open

compiletest: -Zunstable-options for json targets#152236
davidtwco wants to merge 1 commit intorust-lang:mainfrom
davidtwco:compiletest-destabilise-custom-targets

Conversation

@davidtwco
Copy link
Member

@davidtwco davidtwco commented Feb 6, 2026

bootstrap runs compiletest with synthetic custom targets when blessing mir-opt tests, but that no longer works after #150151/#151534 because -Zunstable-options is required

Contexts on Zulips.

@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2026

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 6, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2026

r? @Zalathar

rustbot has assigned @Zalathar.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @jieyouxu, @oli-obk, @wesleywiser, bootstrap
  • @jieyouxu, @oli-obk, @wesleywiser, bootstrap expanded to 8 candidates
  • Random selection from Mark-Simulacrum, Zalathar, clubby789, jieyouxu

Copy link
Member

@SpriteOvO SpriteOvO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my machine, works fine now~

Maybe we should find time to add bless tests to CI, at least ensure it compiles so we don't miss it next time.

View changes since this review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants