[import_granularity] Allow formatting of use behind #[cfg*]#6723
Open
dingxiangfei2009 wants to merge 1 commit intorust-lang:mainfrom
Open
[import_granularity] Allow formatting of use behind #[cfg*]#6723dingxiangfei2009 wants to merge 1 commit intorust-lang:mainfrom
import_granularity] Allow formatting of use behind #[cfg*]#6723dingxiangfei2009 wants to merge 1 commit intorust-lang:mainfrom
Conversation
Fix rust-lang#6666 We would like to allow formatting items with attributes that conceptually allows outer styling as well. Signed-off-by: Xiangfei Ding <dingxiangfei2009@protonmail.ch>
dingxiangfei2009
changed the title
use behind #[cfg*]import_granularity: Allow formatting of use behind #[cfg*]
dingxiangfei2009
changed the title
import_granularity: Allow formatting of use behind #[cfg*]import_granularity] Allow formatting of use behind #[cfg*]
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #6666
Related to #4991
This patch fixes the issue that
import_granularitydoes not applyimport_granuaritytouses behind attributes known to the compiler that the out coding style applies transparently. Attributes like#[cfg],#[cfg_attr],#[warn],#[deny],#[allow].We achieve this by temporarily swap out the default use tree and merge sub-items in a temporary use tree. This tree is then later merged back into the default use tree, with the original attributes grandfathered.