add flag to force newlines in let else statements#6750
Open
yaahc wants to merge 1 commit intorust-lang:mainfrom
Open
add flag to force newlines in let else statements#6750yaahc wants to merge 1 commit intorust-lang:mainfrom
yaahc wants to merge 1 commit intorust-lang:mainfrom
Conversation
| // let-else may be formatted on a single line if they are "short" | ||
| // and only contain a single expression | ||
| let Some(x) = opt | ||
| else { |
Member
There was a problem hiding this comment.
imo if the else clause is short enough you should still be able to have it on one line like so:
let Some(x) = opt
else { return };no need to take 4 lines when 2 is good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag is intended to address a concern @BoxyUwU raised1 about the difficulty of reviewing code containing
let_elseexpressions and how they can easily be confused with if let expressions.Footnotes
https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/.60deny.28clippy.3A.3Amanual_let_else.29.60.20proliferation/near/564564043 ↩