uninstalls toolchains prior to deleting the rustup home folder#2864
Open
Darunada wants to merge 3 commits intorust-lang:mainfrom
Open
uninstalls toolchains prior to deleting the rustup home folder#2864Darunada wants to merge 3 commits intorust-lang:mainfrom
Darunada wants to merge 3 commits intorust-lang:mainfrom
Conversation
kinnison
suggested changes
Nov 8, 2021
Contributor
kinnison
left a comment
kinnison
left a comment
There was a problem hiding this comment.
I'd like to see at least one test validating that this uninstall is happening. Probably it ought to be a new test in tests/cli-self-upd.rs something like an fn uninstall_removes_installed_toolchains()
Author
|
sure thing, work has gotten a bit more stressful in the last couple weeks, I will try to do something this weekend |
Member
|
@Darunada Do you still have time to advance it? If you don't have time I would be happy to help add that test. But it would be great if you could move forward. Thanks! |
Darunada
force-pushed
the
self-uninstall-remove-toolchains
branch
from
10e3130 to
5a9b7a0
Compare
Darunada
force-pushed
the
self-uninstall-remove-toolchains
branch
from
5a9b7a0 to
4abc90a
Compare
Darunada
force-pushed
the
self-uninstall-remove-toolchains
branch
from
2e7c6c9 to
6745cd9
Compare
Author
|
Sorry for the delay, I went ahead and added a test. Let me know if you like the approach! |
0xPoe
suggested changes
Jun 13, 2023
| let no_prompt = m.get_flag("no-prompt"); | ||
|
|
||
| self_update::uninstall(no_prompt) | ||
| fn self_uninstall(cfg: &Cfg, m: &ArgMatches<'_>) -> Result<utils::ExitCode> { |
Member
There was a problem hiding this comment.
I think we don't have a lifetime argument here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2789
I was able to reproduce the issue, and with this change the command now succeeds with the following output.