Add support for [env] in rust-toolchain.toml#2884
Draft
jonhoo wants to merge 1 commit intorust-lang:mainfrom
Draft
Add support for [env] in rust-toolchain.toml#2884jonhoo wants to merge 1 commit intorust-lang:mainfrom
jonhoo wants to merge 1 commit intorust-lang:mainfrom
Conversation
Contributor
|
Thanks Jon, I've marked this as draft for now because until we're confident the decisions are right, I don't want to risk merging this. I'll try and get to code review at some point soonish though, I promise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2883.
Should probably not be merged until the open questions from #2883 are resolved, and notably the implication of the discussion in #2793 is taken into account.