Improve PowerShell completion setup documentation#3131
Improve PowerShell completion setup documentation#3131l0calh05t wants to merge 2 commits intorust-lang:mainfrom
Conversation
|
Sorry for not reviewing this early. You have a lint failure of some sort - either formatting or clippy - if you could fix this we can merge it I think. Thanks! |
If I remember correctly, the error was unrelated to my commit. However, due to the age, the logs had been deleted. I merged the current master to trigger a rerun, now the general checks succeed, but the Linux build failed - again with an error unrelated to my commit: |
|
@l0calh05t our UI tests are failing though. These are new since your PR I think. |
|
@l0calh05t Friendly ping~ Do you have time to update the tests then we can move forward with this PR? Thanks! |
|
I'll try to get around to it this weekend/early next week |
|
@l0calh05t Hi there, and thanks a lot for your contribution! Our team members have changed and now I'm here trying to pick up the lost context. Currently it looks like that #3128 has been closed by @djc's #3444, so I'm wondering if you still have remaining concerns regarding #3128, or we can safely close this PR? Many thanks in advance! |
Fixes #3128