Skip to content

wayland IME: Discard completed delete request#4476

Merged
kchibisov merged 1 commit intorust-windowing:masterfrom
dcz-self:del
Feb 6, 2026
Merged

wayland IME: Discard completed delete request#4476
kchibisov merged 1 commit intorust-windowing:masterfrom
dcz-self:del

Conversation

@dcz-self
Copy link
Contributor

@dcz-self dcz-self commented Feb 6, 2026

This is a fix. The deletion request would repeat until the next deletion request.

It makes me wonder if Option::take() on every value separately is the right choice here. It goes completely unnoticed when missing. Perhaps there should be a .reset() at the end, resetting all the values to default instead.

  • Tested on all platforms changed
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

@dcz-self dcz-self requested a review from kchibisov as a code owner February 6, 2026 14:58
@kchibisov kchibisov merged commit cf9daed into rust-windowing:master Feb 6, 2026
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants