refactor: ssh proxy command + win service least privilege#20
Merged
Conversation
…(workng -firewall rules missing)
11 tasks
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the big refactor, i wanted to move everything forward by one generation with this PR. We now have all ssh commands and use windows service correctly (least privilege). For windows setups there should only be one more potentially breaking update and that is when iroh releases its 1.0.0 sometime in the next couple of months.
Big TODOs for the future:
PR TODOs:
@rjmalagon I want to make sure we nail the "all ssh params" and "windows service" implementations! Could you do some testing on your end and let me know if everything looks good to you? Github actions should create a windows build that you can test with. I create a pre release and link it here in a comment for testing.