Open
Conversation
added 3 commits
September 1, 2023 11:14
cyrus-
changed the title
cyrus-
requested changes
Oct 30, 2023
Contributor
cyrus-
left a comment
cyrus-
left a comment
There was a problem hiding this comment.
partial review, still working through the content
- Remove .DS_Store files throughout
| # This is a convenience script to copy the code examples and corresponding SVG | ||
| # visualizations from the rustviz repository. See README.md for more details. | ||
| RV='../rustviz' | ||
| RV='../rustviz-lifetimeVis' |
Contributor
There was a problem hiding this comment.
this shouldn't be in the final PR
src/SUMMARY.md
Outdated
| - [Vectors](./vectors.md) | ||
| - [Optional: Structures](./structs.md) | ||
| - [Additional Resources](./additional_resources.md) No newline at end of file | ||
| - [Lifetime Calculation](./lifetime.md) |
… familiarity with C++ and we don't want to assume familiarity with Box<T>, but rather want to get to the visualization much more quickly and with a minimal example. Still needs some more revisions but let's start with that.
… making things a bit more concisse.
Contributor
I'm not sure what is happening here -- the diagram and text are referring to lines that don't exist in the code. |
Author
|
newest PR on lifetime:
|
cyrus-
requested changes
Apr 27, 2024
Contributor
cyrus-
left a comment
cyrus-
left a comment
There was a problem hiding this comment.
- Please remove the
.DS_Storefiles manually so they aren't in the diff. - There seems to be a regression in the generated svg's where they render using
&or<instead of the proper character.
| @@ -1 +1,3 @@ | |||
| book | |||
| .vscode | |||
| **/.DS_Store No newline at end of file | |||
Contributor
There was a problem hiding this comment.
please remove the .DS_Store files manually as well
Contributor
There was a problem hiding this comment.
this file seems to have become broken -- it says & now directly in the SVG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.