Skip to content

chore: replace atty with is-terminal #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Unpublished wants to merge 1 commit into from
Closed

chore: replace atty with is-terminal #2467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/lib/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ num_cpus = "1.0"
time = { version = "0.3", features = ["macros", "parsing"] }
memchr = "2" # TODO: Use pear instead.
binascii = "0.1"
atty = "0.2"
is-terminal = "0.4.3"
ref-cast = "1.0"
atomic = "0.5"
parking_lot = "0.12"
Expand Down
3 changes: 2 additions & 1 deletion core/lib/src/log.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,9 @@ pub(crate) fn init(config: &crate::Config) {

// Set Rocket-logger specific settings only if Rocket's logger is set.
if ROCKET_LOGGER_SET.load(Ordering::Acquire) {
use is_terminal::IsTerminal;
// Rocket logs to stdout, so disable coloring if it's not a TTY.
if !atty::is(atty::Stream::Stdout) {
if !std::io::stdout().is_terminal() {
Paint::disable();
}

Expand Down