This repository was archived by the owner on May 6, 2025. It is now read-only.
Conversation
These specs seem to have been failing for a long time: I was not able to find a commit where they were passing.
Fixes a couple failing specs related to missing parameters in pagination links we construct.
sampatbadhe
added a commit
to Kiprosh/google-contacts
that referenced
this pull request
Mar 3, 2016
- Fix timing related specs. - Unescape ampersands from parsed link nodes. - Fixes a couple failing specs related to missing parameters in pagination links we construct. ref - ryanlchan#3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a few specs, some of which seem to have been broken for a while.