Add N5Reader.readShard and N5Writer.writeShard#201
Open
bogovicj wants to merge 8 commits intodevelopmentfrom
Open
Add N5Reader.readShard and N5Writer.writeShard#201bogovicj wants to merge 8 commits intodevelopmentfrom
N5Reader.readShard and N5Writer.writeShard#201bogovicj wants to merge 8 commits intodevelopmentfrom
Conversation
* add a few tests
Contributor
Author
|
Want to highlight this commit 6add658 that addresses an issue that came up during shard deletion. At this time, we need to ensure that this reading happens before a write lock is acquired, hence the fix in the commit above. We may need to revisit this after #202 |
* rather return, leaving the request's blocks as null
* test a list of nulls is returned for non-existing blocks * test number of backend read calls for readBlocks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And a few tests.
see #196