Draft
Conversation
Open
|
@ImSingee Hey now that tRPC 11 has been released (11.0.1 at this time), do you need any help to get this merged? |
johnjensenish
suggested changes
Mar 29, 2025
Comment on lines
+30
to
+46
| // const inputParser = getInputFromInputParsers(procedure._def.inputs) | ||
| // if (typeof inputParser === 'function') { | ||
| // return z.any() | ||
| // } | ||
| // | ||
| // const defaultInputValue = inputParser ? getDefaultForDef(inputParser._def) : '' | ||
| const defaultInputValue = '' | ||
|
|
||
| const procedureType = '' | ||
| const docsType = '' | ||
|
|
||
| // if (inputParser) { | ||
| // const { node } = zodToTs(inputParser) | ||
| // procedureType = `input: ${printNode(node)}` | ||
| // | ||
| // docsType = printNode(createTypeAlias(node, 'input', inputParser.description)) | ||
| // } |
There was a problem hiding this comment.
Can you look into this please?
Found from comment:
#55 (comment)
There was a problem hiding this comment.
It seems like all of the changes in that gist should be in this PR. Thoughts?
| }, | ||
| "dependencies": { | ||
| "@trpc/server": "10.5.0", | ||
| "@trpc/server": "11.0.0-rc.593", |
There was a problem hiding this comment.
This should be changed to 11.0.1 across the board.
| }, | ||
| "peerDependencies": { | ||
| "@trpc/server": "^10" | ||
| "@trpc/server": "11.0.0-rc.593" |
There was a problem hiding this comment.
No need to be strict about peer dependencies.
Suggested change
| "@trpc/server": "11.0.0-rc.593" | |
| "@trpc/server": "^11" |
| }, | ||
| "peerDependencies": { | ||
| "@trpc/server": "^10", | ||
| "@trpc/server": "11.0.0-rc.593", |
There was a problem hiding this comment.
Suggested change
| "@trpc/server": "11.0.0-rc.593", | |
| "@trpc/server": "^11", |
Author
|
Hi @johnjensenish Thanks for your follow up. I won't have time to work on this recently. You can just take my PR and work on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #55
Thanks for @andrewgeorgemitchell and @ax-at
Draft reason: