fix(mention): Reset mentions array on value clear#254
Open
Hiroenzo wants to merge 1 commit intosadmann7:mainfrom
Open
fix(mention): Reset mentions array on value clear#254Hiroenzo wants to merge 1 commit intosadmann7:mainfrom
Hiroenzo wants to merge 1 commit intosadmann7:mainfrom
Conversation
Add effect to reset mentions when input value is cleared
Contributor
|
@Hiroenzo is attempting to deploy a commit to the sadmann7 Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the change does:
Why this is necessary:
Previously, if users cleared the currently selected value completely, the mentions array would retain its previous values, leading to inconsistent state and potential unexpected behavior (e.g., mentions still being processed or displayed despite an empty input). This fix ensures the mentions state always reflects the current input context, maintaining data integrity between the currently selected value and associated mentions.