feat: add circuit breaker configuration to more transaction service endpoints #2904
Conversation
PooyaRaki
force-pushed
the
feat/enableCircuitBreakerForEndpoints
branch
from
66275a3 to
7390ebe
Compare
…t transaction by ID endpoints tests
| circuitBreaker: { | ||
| key: CircuitBreakerKeys.getTransactionServiceKey(chainId), | ||
| }, |
There was a problem hiding this comment.
nitpic: i just realized, that as we are using the same objects across these tests and most values are static, we could also create const with them and reuse instead of passing to each test
There was a problem hiding this comment.
But then you’d need to pass the chainId. How would you handle that?
There was a problem hiding this comment.
for tests there is one chainId = 1 created at the top, no? so nothing changes from test to test
There was a problem hiding this comment.
im fine with keeping it explicit as we do with other params, just with all that refactoring i have been doing i cant unsee the duplication haha :) it is good to go from my side
There was a problem hiding this comment.
Well, for most of them yeah it's 1 except for one test that uses hoodiChainId.
2 participants
Summary
This PR enables the circuit breaker for additional transaction service endpoints.
Changes