Safely build 64-bit binaries along with some modernization.#412
Open
muojp wants to merge 1 commit intosaki4510t:masterfrom
Open
Safely build 64-bit binaries along with some modernization.#412muojp wants to merge 1 commit intosaki4510t:masterfrom
muojp wants to merge 1 commit intosaki4510t:masterfrom
Conversation
Author
|
I'm great to see this happen! Now I'll rebase changes upon the latest master branch. |
Author
|
Now we have only 1 line to change 👍 |
|
Merge this branch is needed because UVCamera library is compiled on 32-bit, causing couldn't find "libjpeg-turbo1500.so" exception if there are 64-bit libraries on the project APP_ABI := all does not compile for me, use APP_ABI := armeabi armeabi-v7a arm64-v8a instead |
|
Also uncomment #NDK_TOOLCHAIN_VERSION := 4.9 line in Application.mk before generating build. Otherwise the library won't work as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-req contains several changes to come over 32-bit/64-bit situation of new Google Play's policy.
Changes made:
APP_ABIbecause recent NDK lacks support for themallis reasonable especially for recent NDKs because at least NDK r18 complainsarmeabiis deprecated.versionBuildToolto align build tools with Android gradle pluginhttpsinstead ofhttpfor URI schema of libcommon to avoid possible DNS poisoning attackNote: According to recent Google's annoucements, APK size issue addressed here is meant to be mitigated via Android App Bundle.
Note: You will see
Android NDK: android-14 is unsupported. Using minimum supported version android-16.warning when built with NDK r18 but you can easilly fix this by specifying older NDKs onlocal.propertiesfile if you really need to keep support for Android 4.0.x. I assume most developers (targetting android-16+) can harmlessly ignore this warning because their app themselves will be compiled withminSdkVersion 16or later.