Skip to content

Comments

Add new handler implementation and shared interfaces#400

Closed
witoszekdev wants to merge 16 commits intomainfrom
add-new-shared-logic
Closed

Add new handler implementation and shared interfaces#400
witoszekdev wants to merge 16 commits intomainfrom
add-new-shared-logic

Conversation

@witoszekdev
Copy link
Member

  • Simplify tsconfig, add aliases
  • Refactor handlers/next -> handlers/platform/next
  • Fix imports
  • Move to shared
  • Fix vitest config
  • Fix failing tests due to change in aliases
  • Add missing shared files
  • Move sync-webhook response builder
  • Refactor commonly used types to shared folder
  • Add deprecated exports notes, add index file
  • Export shared folder
  • Fix broken build
  • Fix broken build
  • Remove re-exports for compatibility
  • Add more shared logic: adapter, validator
  • Add exports, remove saleor domain middleware

@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: 95c2e6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 34.31856% with 400 lines in your changes missing coverage. Please review.

Project coverage is 66.88%. Comparing base (90ea84e) to head (95c2e6b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/handlers/shared/protected-action-validator.ts 0.00% 147 Missing and 1 partial ⚠️
src/handlers/shared/generic-saleor-webhook.ts 0.79% 125 Missing ⚠️
src/handlers/shared/adapter-middleware.ts 25.00% 33 Missing ⚠️
...andlers/platforms/next/create-protected-handler.ts 3.12% 31 Missing ⚠️
src/handlers/shared/saleor-webhook-validator.ts 81.16% 29 Missing ⚠️
src/handlers/shared/protected-handler.ts 9.09% 10 Missing ⚠️
.../handlers/shared/generic-adapter-use-case-types.ts 0.00% 8 Missing and 1 partial ⚠️
src/handlers/shared/index.ts 0.00% 8 Missing and 1 partial ⚠️
...handlers/platforms/next/create-manifest-handler.ts 79.16% 5 Missing ⚠️
src/handlers/platforms/next/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
- Coverage   73.04%   66.88%   -6.17%     
==========================================
  Files          78       88      +10     
  Lines        3024     3521     +497     
  Branches      454      493      +39     
==========================================
+ Hits         2209     2355     +146     
- Misses        810     1159     +349     
- Partials        5        7       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant