Skip to content

Comments

do not require schema version on manifest handler#412

Merged
lkostrowski merged 5 commits intomainfrom
manifest-validation
Feb 27, 2025
Merged

do not require schema version on manifest handler#412
lkostrowski merged 5 commits intomainfrom
manifest-validation

Conversation

@lkostrowski
Copy link
Member

@lkostrowski lkostrowski commented Feb 26, 2025

  • restore schema version to be optional
  • fix bug with parsing saleor schema version to float

@lkostrowski lkostrowski requested a review from a team February 26, 2025 08:16
@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.40%. Comparing base (126493d) to head (562ff3b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
- Coverage   83.44%   83.40%   -0.05%     
==========================================
  Files          98       98              
  Lines        3450     3441       -9     
  Branches      592      588       -4     
==========================================
- Hits         2879     2870       -9     
  Misses        560      560              
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkostrowski lkostrowski marked this pull request as draft February 26, 2025 08:27
@changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2025

🦋 Changeset detected

Latest commit: 562ff3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@saleor/app-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lkostrowski lkostrowski marked this pull request as ready for review February 26, 2025 08:30
@github-actions
Copy link
Contributor

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20250226090519.

Install it with:

pnpm add @saleor/app-sdk@0.0.0-pr-20250226090519

@github-actions
Copy link
Contributor

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20250226101433.

Install it with:

pnpm add @saleor/app-sdk@0.0.0-pr-20250226101433

@lkostrowski lkostrowski merged commit 5fb68e6 into main Feb 27, 2025
10 checks passed
@lkostrowski lkostrowski deleted the manifest-validation branch February 27, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants