Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,9 @@
"require": "./handlers/fetch-api/index.js"
},
"./handlers/next-app-router": {
"types": "./handlers/fetch-api/index.d.ts",
"import": "./handlers/fetch-api/index.mjs",
"require": "./handlers/fetch-api/index.js"
"types": "./handlers/next-app-router/index.d.ts",
"import": "./handlers/next-app-router/index.mjs",
"require": "./handlers/next-app-router/index.js"
},
"./handlers/aws-lambda": {
"types": "./handlers/aws-lambda/index.d.ts",
Expand Down
14 changes: 9 additions & 5 deletions src/APL/saleor-cloud/saleor-cloud-apl.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,17 @@ describe("APL", () => {
saleor_api_url: "https://example.com/graphql/",
jwks: "{}",
token: "example-token",
/**
* Domain is appended to the request body, because APL requires it
*/
domain: "example.com",
}),
headers: {
"Content-Type": "application/json",
Authorization: "Bearer token",
},
method: "POST",
}
},
);
});

Expand All @@ -66,7 +70,7 @@ describe("APL", () => {
const apl = new SaleorCloudAPL(aplConfig);

await expect(apl.set(stubAuthData)).rejects.toThrow(
"Fetch returned with non 200 status code 500"
"Fetch returned with non 200 status code 500",
);
});
});
Expand Down Expand Up @@ -112,7 +116,7 @@ describe("APL", () => {

expect(err.code).toEqual("RESPONSE_BODY_INVALID");
expect(err).toMatchInlineSnapshot(
"[SaleorCloudAplError: Cant parse response body: json error]"
"[SaleorCloudAplError: Cant parse response body: json error]",
);
}
});
Expand Down Expand Up @@ -143,7 +147,7 @@ describe("APL", () => {
Authorization: "Bearer token",
},
method: "GET",
}
},
);
});

Expand Down Expand Up @@ -190,7 +194,7 @@ describe("APL", () => {
Authorization: "Bearer token",
},
method: "GET",
}
},
);
});
});
Expand Down
1 change: 1 addition & 0 deletions src/APL/saleor-cloud/saleor-cloud-apl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ const mapAuthDataToAPIBody = (authData: AuthData) => ({
saleor_api_url: authData.saleorApiUrl,
jwks: authData.jwks,
token: authData.token,
domain: new URL(authData.saleorApiUrl).hostname,
});

const mapAPIResponseToAuthData = (response: CloudAPLAuthDataShape): AuthData => ({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { NextAppRouterAdapter, NextAppRouterHandler } from "./platform-adapter";
export type NextAppRouterProtectedHandler = (
request: NextRequest,
ctx: ProtectedHandlerContext,
) => NextResponse | Promise<NextResponse>;
) => Response | Promise<Response>;

export const createProtectedHandler =
(
Expand Down
8 changes: 4 additions & 4 deletions src/handlers/platforms/next-app-router/platform-adapter.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { NextRequest, NextResponse } from "next/server";
import { NextRequest } from "next/server";

import { WebApiAdapter } from "@/handlers/platforms/fetch-api";

export type NextAppRouterHandlerInput = NextRequest;
export type NextAppRouterHandler = (req: NextRequest) => NextResponse | Promise<NextResponse>;
export type NextAppRouterHandler = (req: NextRequest) => Response | Promise<Response>;

export class NextAppRouterAdapter extends WebApiAdapter<NextRequest, NextResponse> {
export class NextAppRouterAdapter extends WebApiAdapter<NextRequest> {
constructor(public request: NextRequest) {
super(request, NextResponse);
super(request, Response);

Check warning on line 10 in src/handlers/platforms/next-app-router/platform-adapter.ts

View check run for this annotation

Codecov / codecov/patch

src/handlers/platforms/next-app-router/platform-adapter.ts#L10

Added line #L10 was not covered by tests
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
import { NextResponse } from "next/server";
import { describe, expect, it } from "vitest";

import { FileAPL } from "@/APL/file";
import { SaleorSyncWebhook } from "@/handlers/platforms/next-app-router";

describe("SaleorSyncWebhook (Next App Router)", () => {
it("Constructs (and types are right)", () => {
/**
* This test doesn't test anything in the runtime.
* It's meant to ensure types are correct. If types are wrong, the project will not compile.
*/
expect.assertions(0);

const handler = new SaleorSyncWebhook<{ foo: string }>({
apl: new FileAPL(),
event: "CHECKOUT_CALCULATE_TAXES",
name: "asd",
query: "{}",
webhookPath: "/",
});

handler.createHandler((req, ctx) => {
const { body } = req;

const { event } = ctx;

return NextResponse.json({
event,
body,
});
});
});
});
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { NextRequest, NextResponse } from "next/server";
import { NextRequest } from "next/server";

import { createDebug } from "@/debug";
import { WebApiWebhookHandler } from "@/handlers/platforms/fetch-api";
Expand All @@ -22,15 +22,15 @@ export type WebhookConfig<Event = AsyncWebhookEventType | SyncWebhookEventType>
export type NextAppRouterWebhookHandler<
TPayload = unknown,
TRequest extends NextRequest = NextRequest,
TResponse extends NextResponse = NextResponse,
TResponse extends Response = Response,
> = WebApiWebhookHandler<TPayload, TRequest, TResponse>;

export abstract class SaleorNextAppRouterWebhook<TPayload = unknown> extends GenericSaleorWebhook<
NextAppRouterHandlerInput,
TPayload
> {
createHandler(handlerFn: NextAppRouterWebhookHandler<TPayload>): NextAppRouterHandler {
return async (req): Promise<NextResponse> => {
return async (req): Promise<Response> => {
const adapter = new NextAppRouterAdapter(req);
const prepareRequestResult = await super.prepareRequest<NextAppRouterAdapter>(adapter);

Expand Down
Loading