Skip to content

Comments

add next js filename suffix to fix esm#424

Merged
lkostrowski merged 7 commits intomainfrom
fix-esm
Apr 8, 2025
Merged

add next js filename suffix to fix esm#424
lkostrowski merged 7 commits intomainfrom
fix-esm

Conversation

@lkostrowski
Copy link
Member

@lkostrowski lkostrowski commented Apr 8, 2025

@changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2025

🦋 Changeset detected

Latest commit: 743731a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@saleor/app-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20250408064159.

Install it with:

pnpm add @saleor/app-sdk@0.0.0-pr-20250408064159

@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.81%. Comparing base (2dca0f8) to head (743731a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #424   +/-   ##
=======================================
  Coverage   83.81%   83.81%           
=======================================
  Files         107      107           
  Lines        3497     3497           
  Branches      588      588           
=======================================
  Hits         2931     2931           
  Misses        555      555           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20250408065642.

Install it with:

pnpm add @saleor/app-sdk@0.0.0-pr-20250408065642

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20250408084124.

Install it with:

pnpm add @saleor/app-sdk@0.0.0-pr-20250408084124

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20250408085129.

Install it with:

pnpm add @saleor/app-sdk@0.0.0-pr-20250408085129

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20250408085803.

Install it with:

pnpm add @saleor/app-sdk@0.0.0-pr-20250408085803

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20250408090356.

Install it with:

pnpm add @saleor/app-sdk@0.0.0-pr-20250408090356

@lkostrowski lkostrowski marked this pull request as ready for review April 8, 2025 09:05
@lkostrowski lkostrowski requested a review from a team April 8, 2025 09:05
@witoszekdev
Copy link
Member

Nice tool for checking libraries exports, we can maybe add it to CI / git hooks since they have a CLI: https://www.npmjs.com/package/@arethetypeswrong/cli

@lkostrowski lkostrowski merged commit 9849e55 into main Apr 8, 2025
9 checks passed
@lkostrowski lkostrowski deleted the fix-esm branch April 8, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants