Conversation
…JSON schema for webhook response payloads
🦋 Changeset detectedLatest commit: 5b65f5c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #444 +/- ##
=======================================
Coverage 83.87% 83.87%
=======================================
Files 107 107
Lines 3511 3511
Branches 591 591
=======================================
Hits 2945 2945
Misses 555 555
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| * @deprecated Saleor now exposes JSON schema for webhook response payloads that can be used to generate TypeScript types. See https://docs.saleor.io/developer/extending/apps/developing-apps/generating-types-for-sync-webhooks for more details. | ||
| * |
There was a problem hiding this comment.
maybe we should generate types in SDK instead? So you don't have to regenerate them in every app?
There was a problem hiding this comment.
We can - but I think it will the best if we have app-sdk version connected to Saleor version. Then we can generate JSON schema types + GraphQL types as well
Deprecate
buildSyncWebhookResponsePayloadfunction. Saleor now exposes JSON schema for webhook response payloads that can be used to generate TypeScript types. See Saleor docs for more info.