Skip to content

Comments

more verbose "Failed to generate action ID" error#490

Merged
lkostrowski merged 3 commits intosaleor:mainfrom
djkato:action-id-error
Feb 16, 2026
Merged

more verbose "Failed to generate action ID" error#490
lkostrowski merged 3 commits intosaleor:mainfrom
djkato:action-id-error

Conversation

@djkato
Copy link
Contributor

@djkato djkato commented Feb 11, 2026

I wasted like 30 mins trying to figure out why this is happening and how I can develop on any other ip/domain besides localhost/127.0.0.1. This should help guide devs who will enavitably run into this issue faster to setting up their env so they can continue, eg: add their IP/domain to "dom.securecontext.allowlist".

I wasted like 30 mins trying to figure out why this is happening and how
I can develop on any other ip/domain besides localhost/127.0.0.1. This
should help guide devs who will enavitably run into this issue faster to
setting up the env so they can continue, eg: add their IP/domain to
"dom.securecontext.allowlist".
@djkato djkato requested a review from a team as a code owner February 11, 2026 20:39
@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2026

🦋 Changeset detected

Latest commit: dc9ff43

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

lkostrowski
lkostrowski previously approved these changes Feb 11, 2026
lkostrowski
lkostrowski previously approved these changes Feb 11, 2026
@lkostrowski
Copy link
Member

you need to fix test to assert new message

witoszekdev
witoszekdev previously approved these changes Feb 12, 2026
@djkato djkato dismissed stale reviews from witoszekdev and lkostrowski via dc9ff43 February 12, 2026 13:26
@djkato djkato requested a review from lkostrowski February 12, 2026 13:28
@djkato
Copy link
Contributor Author

djkato commented Feb 12, 2026

sorry, not sure how these reviews work yet. Do I have to request re-review every change or am I just being rude and spamming your inbox? xD
so much work just to change an error message, gee

@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.25%. Comparing base (a057ce8) to head (dc9ff43).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #490   +/-   ##
=======================================
  Coverage   86.25%   86.25%           
=======================================
  Files          86       86           
  Lines        1571     1571           
  Branches      261      261           
=======================================
  Hits         1355     1355           
  Misses        197      197           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lkostrowski lkostrowski merged commit 9440baf into saleor:main Feb 16, 2026
6 checks passed
@lkostrowski
Copy link
Member

lkostrowski commented Feb 16, 2026

Do I have to request re-review every change or am I just being rude and spamming your inbox? xD

if you don't re-request, we will not be notified and not see your changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants