Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
witoszekdev
requested changes
Aug 1, 2025
Comment on lines
10
to
13
| private getAppBaseUrlAbsolute(appId: string, saleorApiUrl: string) { | ||
| const saleorDashboardUrl = saleorApiUrl.replace("/graphql/", ""); | ||
| return `${saleorDashboardUrl}${this.getAppBaseUrlRelative(appId)}`; | ||
| } |
Member
There was a problem hiding this comment.
issue: please remove it since it's no longer used
Suggested change
| private getAppBaseUrlAbsolute(appId: string, saleorApiUrl: string) { | |
| const saleorDashboardUrl = saleorApiUrl.replace("/graphql/", ""); | |
| return `${saleorDashboardUrl}${this.getAppBaseUrlRelative(appId)}`; | |
| } |
Contributor
Author
There was a problem hiding this comment.
It is used inside:
getTransactionDetailsUrl(transactionId: string) {
const baseUrl = this.getAppBaseUrlAbsolute(this.authData.appId, this.authData.saleorApiUrl);
return `${baseUrl}/transactions/${transactionId}`;
}| const baseUrl = includeSaleorBaseUrl | ||
| ? this.getAppBaseUrlAbsolute(this.authData.appId, this.authData.saleorApiUrl) | ||
| : this.getAppBaseUrlRelative(this.authData.appId); | ||
| getTransactionDetailsUrl(transactionId: string) { |
Member
There was a problem hiding this comment.
question: is this correct? don't we need to add Saleor URL? If so then maybe we should a link to docs here 😄
Contributor
Author
There was a problem hiding this comment.
after this change we always add Saleor URL (via getAppBaseUrlAbsolute)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes url generated by app to always be with baseUrl with properly encoded app id