Force resolving react from node_modules of the app#292
Merged
lkostrowski merged 1 commit intomainfrom Feb 3, 2026
Merged
Conversation
witoszekdev
approved these changes
Feb 3, 2026
Comment on lines
+6
to
+19
| webpack: (config) => { | ||
| // When using `pnpm link` for local SDK development, webpack may resolve | ||
| // react/react-dom from the linked package's node_modules (different version), | ||
| // causing the "two Reacts" problem. Force resolution to this project's copy. | ||
| config.resolve = { | ||
| ...config.resolve, | ||
| alias: { | ||
| ...config.resolve?.alias, | ||
| react: path.resolve("./node_modules/react"), | ||
| "react-dom": path.resolve("./node_modules/react-dom"), | ||
| }, | ||
| }; | ||
| return config; | ||
| }, |
Member
There was a problem hiding this comment.
suggestion: maybe we should also add this to saleor/apps monorepo as shared config?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is fix for local development. When
pnpm linkis used (eg to develop app-sdk), app-sdk is using it's own React, while app is using own.This config ensures react is always pointing at React in app's node_modules, not linked package