Conversation
🦋 Changeset detectedLatest commit: 78f482a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
michalina-graczyk
dismissed stale reviews from poulch and szczecha
via
263699e
| const selectedLinkType = await this.menuLinkType.inputValue(); | ||
|
|
||
| if (selectedLinkType !== linkType) { | ||
| throw new Error(`Expected link type "${linkType}" but found "${selectedLinkType}"`); |
There was a problem hiding this comment.
this should be an assert, not exception raising, this will break the test execution by unhandled error
| await this.menuLinkOptions.filter({ hasText: option }).click({ force: true }); | ||
| await this.waitForDOMToFullyLoad(); | ||
|
|
||
| // Ensure the link type option is visible and select it |
There was a problem hiding this comment.
LLM models generate usually tons on comments, explaining what they do - it's useful when composing the final solution, but usually redundant when used in the destined codebase.
|
This pull request is stale because it has been open 14 days with no activity. |
|
This PR request has been closed because it has been stalled for 2 days with no activity. You are still welcome to reopen it and continue from where you finished. Best regards Saleor team |
4 participants
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description