Skip to content

Add explicit waits for draft order shipping carrier button interaction #5324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michalina-graczyk merged 4 commits into from
Dec 27, 2024
Merged

Add explicit waits for draft order shipping carrier button interaction #5324

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6d9aad4
Add explicit waits for draft order shipping carrier button interaction
Dec 17, 2024
ceca6d1
Merge branch 'main' into MERX-1370-saleor_84-improvment
Dec 18, 2024
caa80b6
Add fixes from review
Dec 18, 2024
3899cf2
Merge branch 'main' into MERX-1370-saleor_84-improvment
Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thin-drinks-kneel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"saleor-dashboard": patch
---

Add explicit waits for draft order shipping carrier button interaction
8 changes: 8 additions & 0 deletions playwright/pages/draftOrdersPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,14 @@ export class DraftOrdersPage extends BasePage {
}

async clickAddShippingCarrierButton() {
await this.page.waitForLoadState("networkidle");
Copy link
Contributor

@andrzejewsky andrzejewsky Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://playwright.dev/docs/api/class-page#page-wait-for-load-state

Especially:

Most of the time, this method is not needed because Playwright auto-waits before every action.

and:

'networkidle' - DISCOURAGED wait until there are no network connections for at least 500 ms. Don't use this method for testing, rely on web assertions to assess readiness instead.


await this.addShippingCarrierLink.waitFor({
state: "visible",
timeout: 10000,
Copy link
Contributor

@andrzejewsky andrzejewsky Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not add hardcoded timeout, rather we should rethink the test if it stucks somwhere.

});

await this.addShippingCarrierLink.scrollIntoViewIfNeeded();
await this.addShippingCarrierLink.click();
await this.waitForDOMToFullyLoad();
}
Expand Down
6 changes: 5 additions & 1 deletion playwright/tests/orders.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,13 @@ test("TC: SALEOR_84 Create draft order @e2e @draft", async () => {
await draftOrdersPage.expectSuccessBanner();
await draftOrdersPage.addressDialog.clickConfirmButton();
await draftOrdersPage.expectSuccessBanner();

await draftOrdersPage.addShippingCarrierLink.waitFor({ state: "visible", timeout: 10000 });
// Ensure the button is in viewport before clicking
await draftOrdersPage.addShippingCarrierLink.scrollIntoViewIfNeeded();
await draftOrdersPage.clickAddShippingCarrierButton();

await draftOrdersPage.shippingAddressDialog.pickAndConfirmFirstShippingMethod();
//await draftOrdersPage.expectSuccessBanner();
await draftOrdersPage.clickFinalizeButton();
await draftOrdersPage.expectSuccessBanner({ message: "finalized" });
});
Expand Down