Conversation
🦋 Changeset detectedLatest commit: ced98be The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| emitter.blurRightOperator(index); | ||
| }} | ||
| error={error} | ||
| placeholder="Key" |
There was a problem hiding this comment.
Suggestion: I think we're missing translations here
andrzejewsky
added
run pw-e2e
| disabled: boolean; | ||
| } | ||
|
|
||
| export const MetadataInput = ({ |
There was a problem hiding this comment.
suggestion: WDYT about make this component more generic and name it like DoubleTextInput?
There was a problem hiding this comment.
I had that in the beginning, but metadata is specific field so i wanted to create something dedicated to this, in case we need to change something just for metadata. Double text input makes sense, but... i cannot foresee what will be needed in the future and want to avoid latter on eg. TripleTextInput etc.
andrzejewsky
added
run pw-e2e
* Metadata filter * Fix styling * Fix styling * Fix tuples * Fix pagination * Translations * Extract messages --------- Co-authored-by: Paweł Chyła <chyla1988@gmail.com>
3 participants
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description