Skip to content

Add password to artifact#5334

Merged
karola312 merged 10 commits intomainfrom
qag-258-Secure-tokens-in-artifacts
Feb 18, 2025
Merged

Add password to artifact#5334
karola312 merged 10 commits intomainfrom
qag-258-Secure-tokens-in-artifacts

Conversation

@karola312
Copy link
Contributor

@karola312 karola312 commented Jan 4, 2025

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

@changeset-bot
Copy link

changeset-bot bot commented Jan 4, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: e8b9af7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@karola312 karola312 added the run pw-e2e Run e2e (basic suite from PR automation) label Jan 4, 2025
@github-actions github-actions bot temporarily deployed to pr-5334 January 4, 2025 15:37 Destroyed
@karola312 karola312 marked this pull request as ready for review January 4, 2025 17:04
@karola312 karola312 requested a review from a team January 4, 2025 17:04
@andrzejewsky andrzejewsky added run pw-e2e Run e2e (basic suite from PR automation) and removed run pw-e2e Run e2e (basic suite from PR automation) labels Jan 10, 2025
@andrzejewsky andrzejewsky self-requested a review January 10, 2025 09:44
andrzejewsky
andrzejewsky suggested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@andrzejewsky andrzejewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach changeset file.

@github-actions github-actions bot temporarily deployed to pr-5334 January 10, 2025 09:45 Destroyed
@karola312 karola312 requested a review from a team as a code owner January 10, 2025 09:57
@github-actions github-actions bot temporarily deployed to pr-5334 January 10, 2025 10:00 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5334 January 10, 2025 22:36 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5334 January 15, 2025 11:14 Destroyed
witoszekdev
witoszekdev previously approved these changes Jan 29, 2025
View reviewed changes
@karola312 karola312 requested a review from a team February 5, 2025 09:13
@github-actions github-actions bot temporarily deployed to pr-5334 February 5, 2025 09:16 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5334 February 5, 2025 11:35 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5334 February 5, 2025 13:41 Destroyed
@karola312 karola312 requested a review from witoszekdev February 5, 2025 22:59
@github-actions github-actions bot temporarily deployed to pr-5334 February 5, 2025 23:02 Destroyed
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025 •
edited
Loading

merge-reports: Run #4446

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
235 235 0 0 0 0 0 4m50s

🎉 All tests passed!

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

witoszekdev
witoszekdev previously approved these changes Feb 11, 2025
View reviewed changes
andrzejewsky
andrzejewsky previously approved these changes Feb 11, 2025
View reviewed changes
.github/workflows/run-test-manual.yml Outdated
- name: Merge playwright reports
uses: ./.github/actions/merge-pw-reports
with:
PASSWORD_FOR_DECODING_ARTIFACT: ${{ secrets.E2E_USER_PASSWORD }}
Copy link
Contributor

@andrzejewsky andrzejewsky Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure to use exact same password as for user login? isn't better to have separate variable for it?

Copy link
Contributor Author

@karola312 karola312 Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if anyone had our user password, separate password for tests results won't do much good

Copy link
Contributor

@andrzejewsky andrzejewsky Feb 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the password can stay the same, the new variable can point to it, I'm saying that we share the same variable for 2 different things

Copy link
Contributor Author

@karola312 karola312 Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

@karola312 karola312 requested a review from a team February 12, 2025 10:05
@codecov
Copy link

codecov bot commented Feb 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.73%. Comparing base (1644a09) to head (e8b9af7).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #5334    +/-   ##
========================================
  Coverage   61.73%   61.73%            
========================================
  Files        1251     1251            
  Lines       21783    21783            
  Branches     4543     4543            
========================================
  Hits        13448    13448            
- Misses       7784     8298   +514     
+ Partials      551       37   -514

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pr-5334 February 17, 2025 09:59 Destroyed
@karola312 karola312 dismissed stale reviews from witoszekdev and andrzejewsky via 39f90d8 February 17, 2025 10:59
@github-actions github-actions bot temporarily deployed to pr-5334 February 17, 2025 11:01 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5334 February 17, 2025 11:23 Destroyed
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2025 •
edited
Loading

merge-reports: Run #4490

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
235 235 0 0 0 0 0 5m3s

🎉 All tests passed!

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@karola312 karola312 merged commit 83606ae into main Feb 18, 2025
17 checks passed
@karola312 karola312 deleted the qag-258-Secure-tokens-in-artifacts branch February 18, 2025 11:27
witoszekdev pushed a commit that referenced this pull request Feb 18, 2025
@karola312 @poulch @witoszekdev
Add password to artifact (#5334)
edf962c 
* Add password to artifact

* Add changeset

* Fix upload artifact action

* Change password

---------

Co-authored-by: Paweł Chyła <chyla1988@gmail.com>
@szczecha szczecha mentioned this pull request Mar 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@witoszekdev witoszekdev witoszekdev approved these changes

@kzuraw kzuraw Awaiting requested review from kzuraw kzuraw is a code owner automatically assigned from saleor/js

+1 more reviewer

@andrzejewsky andrzejewsky andrzejewsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

run pw-e2e Run e2e (basic suite from PR automation)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@karola312 @witoszekdev @andrzejewsky @poulch