-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Custom auth header in GraphiQL Playground #5336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "saleor-dashboard": patch | ||
| --- | ||
|
|
||
| You can now use custom auth headers in graphiql dev mode panel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| import { createGraphiQLFetcher, FetcherOpts } from "@graphiql/toolkit"; | ||
| import { createFetch } from "@saleor/sdk"; | ||
|
|
||
| import { getFetcher } from "./utils"; | ||
|
|
||
| jest.mock("@graphiql/toolkit", () => ({ | ||
| createGraphiQLFetcher: jest.fn(), | ||
| })); | ||
|
|
||
| jest.mock("@saleor/sdk", () => ({ | ||
| createFetch: jest.fn().mockReturnValue(jest.fn()), | ||
| })); | ||
|
|
||
| const mockCreateGraphiQLFetcher = createGraphiQLFetcher as jest.Mock; | ||
| const authorizedFetch = createFetch as jest.Mock; | ||
|
|
||
| describe("getFetcher", () => { | ||
| const mockApiUrl = "http://test-api.com"; | ||
| let originalFetch: typeof fetch; | ||
|
|
||
| beforeEach(() => { | ||
| process.env.API_URL = mockApiUrl; | ||
| originalFetch = global.fetch; | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| jest.resetAllMocks(); | ||
| global.fetch = originalFetch; | ||
| }); | ||
|
|
||
| it("should return fetcher with authorizedFetch when no auth headers", () => { | ||
| // Arrange | ||
| const opts: FetcherOpts = { headers: {} }; | ||
|
|
||
| // Act | ||
| getFetcher(opts); | ||
|
|
||
| // Assert | ||
| expect(authorizedFetch).toHaveBeenCalled(); | ||
| // 'toHaveBeenCalledWith' can't properly compare mock functions | ||
| expect(mockCreateGraphiQLFetcher).toHaveBeenCalledWith( | ||
| expect.objectContaining({ | ||
| url: mockApiUrl, | ||
| }), | ||
| ); | ||
| }); | ||
|
|
||
| it("should return fetcher with fetch when Authorization header present", () => { | ||
| // Arrange | ||
| const opts: FetcherOpts = { | ||
| headers: { Authorization: "Bearer token" }, | ||
| }; | ||
|
|
||
| // Act | ||
| getFetcher(opts); | ||
|
|
||
| // Assert | ||
| expect(mockCreateGraphiQLFetcher).toHaveBeenCalledWith({ | ||
| url: mockApiUrl, | ||
| fetch: fetch, | ||
| }); | ||
| }); | ||
|
|
||
| it("should return fetcher with fetch when Authorization-Bearer header present", () => { | ||
| // Arrange | ||
| const opts: FetcherOpts = { | ||
| headers: { "Authorization-Bearer": "token" }, | ||
| }; | ||
|
|
||
| // Act | ||
| getFetcher(opts); | ||
|
|
||
| // Assert | ||
| expect(mockCreateGraphiQLFetcher).toHaveBeenCalledWith({ | ||
| url: mockApiUrl, | ||
| fetch: fetch, | ||
| }); | ||
| }); | ||
|
|
||
| it("should return fetcher with fetch when lowercase header present", () => { | ||
| // Arrange | ||
| const opts: FetcherOpts = { | ||
| headers: { "authorization-bearer": "token" }, | ||
| }; | ||
|
|
||
| // Act | ||
| getFetcher(opts); | ||
|
|
||
| // Assert | ||
| expect(mockCreateGraphiQLFetcher).toHaveBeenCalledWith({ | ||
| url: mockApiUrl, | ||
| fetch: fetch, | ||
| }); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { createGraphiQLFetcher, FetcherOpts } from "@graphiql/toolkit"; | ||
| import { createFetch } from "@saleor/sdk"; | ||
|
|
||
| const authHeaders = ["Authorization", "Authorization-Bearer"]; | ||
|
|
||
| const authorizedFetch = createFetch(); | ||
|
|
||
| export const getFetcher = (opts: FetcherOpts) => { | ||
| let httpFetch = authorizedFetch; | ||
|
|
||
| const hasAuthorizationHeaders = | ||
| opts.headers && | ||
| authHeaders.some(header => opts.headers![header] || opts.headers![header.toLowerCase()]); | ||
|
|
||
| if (hasAuthorizationHeaders) { | ||
| httpFetch = fetch; | ||
poulch marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| return createGraphiQLFetcher({ | ||
| url: process.env.API_URL as string, | ||
| fetch: httpFetch as typeof fetch, | ||
| }); | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.