Skip to content

Update buttons in customer and gift card components#5348

Merged
poulch merged 6 commits intomainfrom
MERX-1186-buttons-gift-cards-unify
Jan 16, 2025
Merged

Update buttons in customer and gift card components#5348
poulch merged 6 commits intomainfrom
MERX-1186-buttons-gift-cards-unify

Conversation

@Cloud11PL
Copy link
Contributor

@Cloud11PL Cloud11PL commented Jan 13, 2025 •
edited
Loading

Scope of the change

  • Updates buttons in gift card details view
  • Updates buttons in customer details view
  • Updates some inputs

CleanShot 2025-01-13 at 15 22 19

CleanShot 2025-01-13 at 15 23 09

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 741c69d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5348 January 13, 2025 14:26 Destroyed
@Cloud11PL Cloud11PL added the run pw-e2e Run e2e (basic suite from PR automation) label Jan 13, 2025
@github-actions github-actions bot temporarily deployed to pr-5348 January 13, 2025 16:29 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5348 January 13, 2025 17:49 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5348 January 13, 2025 18:03 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5348 January 13, 2025 18:25 Destroyed
@Cloud11PL Cloud11PL marked this pull request as ready for review January 13, 2025 18:36
@Cloud11PL Cloud11PL requested a review from a team January 13, 2025 18:36
@Cloud11PL Cloud11PL requested a review from a team as a code owner January 13, 2025 18:36
@Cloud11PL Cloud11PL requested review from kzuraw and poulch January 13, 2025 18:36
@github-actions github-actions bot temporarily deployed to pr-5348 January 13, 2025 21:02 Destroyed
@szczecha
Copy link
Member

szczecha commented Jan 14, 2025 •
edited
Loading

After updating the gift card balance, the dashboard does NOT update with the new value, the user has to refresh the page. I checked the main branch and after updating the balance dashboard calls GiftCardDetails

Screen.Recording.2025-01-14.at.10.07.46.mov

@Cloud11PL
Copy link
Contributor Author

Cloud11PL commented Jan 14, 2025 •
edited
Loading

@szczecha Hey, I just checked on v320 deployment and master deployment and both do not call GiftCardDetails after the update. This PR doesn't change anything in the update logic. I will make a separate ticket for it

@szczecha
Copy link
Member

szczecha commented Jan 14, 2025

@szczecha Hey, I just checked on v320 deployment and master deployment and on both do not call GiftCardDetails after the update. This PR doesn't change anything in the update logic. I will make a separate ticket for it

Hmm maybe I stepped on a case when the token expires and that's why it refresh balance

@github-actions github-actions bot temporarily deployed to pr-5348 January 16, 2025 09:11 Destroyed
@poulch poulch enabled auto-merge (squash) January 16, 2025 13:21
@poulch poulch merged commit fbfc969 into main Jan 16, 2025
15 checks passed
@poulch poulch deleted the MERX-1186-buttons-gift-cards-unify branch January 16, 2025 13:22
poulch added a commit that referenced this pull request Jan 16, 2025
@Cloud11PL @poulch
Update buttons in customer and gift card components (#5348)
616ad52 
* update buttons in customer and gift card components

* changeset

* update e2e

---------

Co-authored-by: Paweł Chyła <chyla1988@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szczecha szczecha szczecha approved these changes

@kzuraw kzuraw Awaiting requested review from kzuraw kzuraw is a code owner automatically assigned from saleor/js

+2 more reviewers

@andrzejewsky andrzejewsky andrzejewsky approved these changes

@poulch poulch poulch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

run pw-e2e Run e2e (basic suite from PR automation)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Cloud11PL @szczecha @andrzejewsky @poulch