Skip to content

Use # in tests tags 319#5383

Merged
szczecha merged 1 commit into3.19from
qa-282-replace-tags-in-tests-319
Feb 5, 2025
Merged

Use # in tests tags 319#5383
szczecha merged 1 commit into3.19from
qa-282-replace-tags-in-tests-319

Conversation

@szczecha
Copy link
Member

@szczecha szczecha commented Jan 30, 2025

Scope of the change

While working on adding #5356 (comment), we realized that our test tags match the GitHub usernames of actual users. This unintentionally mentions them in reports, which is not ideal.
image

Internal task: https://linear.app/saleor/issue/QA-282/

It should be merged along with:
#5382
#5379

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2025

🦋 Changeset detected

Latest commit: 3c5c575

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@szczecha szczecha added the run pw-e2e Run e2e (basic suite from PR automation) label Jan 30, 2025
@github-actions github-actions bot temporarily deployed to pr-5383 January 30, 2025 14:49 Destroyed
@szczecha szczecha changed the title Replace @ with # in test tags 319 Use # in tests tags 319 Jan 31, 2025
@szczecha szczecha marked this pull request as ready for review February 3, 2025 08:03
@szczecha szczecha requested a review from a team February 3, 2025 08:03
This was referenced Feb 3, 2025
@szczecha szczecha requested a review from a team February 3, 2025 08:08
@szczecha szczecha merged commit e62b553 into 3.19 Feb 5, 2025
13 checks passed
@szczecha szczecha deleted the qa-282-replace-tags-in-tests-319 branch February 5, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run pw-e2e Run e2e (basic suite from PR automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants