Conversation
🦋 Changeset detectedLatest commit: a2cbf3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
merge-reports: Run #4360
🎉 All tests passed!Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
| ? mapNodeToChoice(availableChannels, channel => channel.slug) | ||
| : null; | ||
| const selectedChannel = availableChannels.find(channel => channel.slug === params.channel); | ||
| // const selectedChannel = availableChannels.find(channel => channel.slug === params.channel); |
There was a problem hiding this comment.
leftover comment
| // const selectedChannel = availableChannels.find(channel => channel.slug === params.channel); |
| if (rowType === "ids") { | ||
| return new NoopValuesHandler([]); | ||
| } |
There was a problem hiding this comment.
question: Isn't this the same as next condition?
| if (rowType === "ids") { | |
| return new NoopValuesHandler([]); | |
| } |
| "string": "General information" | ||
| }, | ||
| "ThUvIL": { | ||
| "string": "Hidden" |
There was a problem hiding this comment.
suggestion: Let's add context for these strings, e.g.:
| "string": "Hidden" | |
| "context": "Collection filter condition", | |
| "string": "Hidden" |
| "string": "No channels selected" | ||
| }, | ||
| "w7tf2z": { | ||
| "string": "Published" |
There was a problem hiding this comment.
suggestion: maybe we should use yes/no label values for this? When you look at the condition as a filter, then it looks incorrect:
Published is Published 😅
There was a problem hiding this comment.
or maybe we can change the field name to Visibility, so that it becomes:
Visibility is Published
Visibility is Hidden
merge-reports: Run #4366
🎉 All tests passed!Github Test Reporter by CTRF 💚 |
* Collection filters * channel fix * published labels * ids and slugs * collection filters * update test * json messages * remove ids and slugs filters * Refactor * Update flag * Restore collection list * Refactor statics --------- Co-authored-by: Paweł Chyła <pawel.chyla@saleor.io>
4 participants
Scope of the change