Skip to content

Comments

Migrate from tabs to filter presets in product types list#5409

Merged
poulch merged 4 commits intomainfrom
bck-1448-page-types-layout
Feb 14, 2025
Merged

Migrate from tabs to filter presets in product types list#5409
poulch merged 4 commits intomainfrom
bck-1448-page-types-layout

Conversation

@poulch
Copy link
Contributor

@poulch poulch commented Feb 13, 2025

Scope of the change

Before:
Screenshot 2025-02-14 at 10 42 08

After:
Screenshot 2025-02-14 at 10 41 49

@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2025

🦋 Changeset detected

Latest commit: 4985dba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 61.90%. Comparing base (08e1b2e) to head (4985dba).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...onents/ProductTypeListPage/ProductTypeListPage.tsx 60.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5409   +/-   ##
=======================================
  Coverage   61.90%   61.90%           
=======================================
  Files        1241     1241           
  Lines       21436    21439    +3     
  Branches     4458     4472   +14     
=======================================
+ Hits        13270    13272    +2     
- Misses       7623     7624    +1     
  Partials      543      543           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pr-5409 February 13, 2025 16:13 Destroyed
@poulch poulch marked this pull request as ready for review February 14, 2025 09:41
@poulch poulch requested a review from a team February 14, 2025 09:41
@poulch poulch added the run pw-e2e Run e2e (basic suite from PR automation) label Feb 14, 2025
@github-actions github-actions bot temporarily deployed to pr-5409 February 14, 2025 09:43 Destroyed
@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2025

merge-reports: Run #4400

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
235 235 0 0 0 0 0 5m19s

🎉 All tests passed!

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@github-actions github-actions bot temporarily deployed to pr-5409 February 14, 2025 10:06 Destroyed
andrzejewsky
andrzejewsky previously approved these changes Feb 14, 2025
@@ -1,32 +1,30 @@
// @ts-strict-ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: can we get rid of this? or is it still needed for some reason?
if so we can add a comment ;)

@github-actions
Copy link
Contributor

merge-reports: Run #4422

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
235 235 0 0 0 0 0 4m52s

🎉 All tests passed!

Github Test Reporter by CTRF 💚

@poulch poulch merged commit d2f32cb into main Feb 14, 2025
17 checks passed
@poulch poulch deleted the bck-1448-page-types-layout branch February 14, 2025 15:08
witoszekdev pushed a commit that referenced this pull request Feb 18, 2025
* Migrate from tabs to filter presets

* Add changeset

* Update test id

* CR fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run pw-e2e Run e2e (basic suite from PR automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants