Skip to content

Comments

Introduce new filters for product types#5411

Merged
poulch merged 10 commits intomainfrom
bck-1448-product-types-filers
Feb 17, 2025
Merged

Introduce new filters for product types#5411
poulch merged 10 commits intomainfrom
bck-1448-product-types-filers

Conversation

@poulch
Copy link
Contributor

@poulch poulch commented Feb 14, 2025

Scope of the change

@changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2025

🦋 Changeset detected

Latest commit: 180b11d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 56.45161% with 54 lines in your changes missing coverage. Please review.

Project coverage is 61.92%. Comparing base (d2f32cb) to head (180b11d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...er/API/providers/ProductTypesFilterAPIProvider.tsx 27.77% 13 Missing ⚠️
...alState/productTypes/useInitialProdutTypesState.ts 37.50% 10 Missing ⚠️
src/components/ConditionalFilter/API/intl.ts 10.00% 9 Missing ⚠️
.../components/ConditionalFilter/context/provider.tsx 27.27% 8 Missing ⚠️
...onents/ProductTypeListPage/ProductTypeListPage.tsx 20.00% 4 Missing ⚠️
...tialState/productTypes/InitialProductTypesState.ts 84.21% 3 Missing ⚠️
...onditionalFilter/ValueProvider/TokenArray/index.ts 0.00% 3 Missing ⚠️
...itionalFilter/ValueProvider/useUrlValueProvider.ts 0.00% 3 Missing ⚠️
...lFilter/ValueProvider/TokenArray/fetchingParams.ts 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5411      +/-   ##
==========================================
+ Coverage   61.90%   61.92%   +0.02%     
==========================================
  Files        1241     1245       +4     
  Lines       21439    21530      +91     
  Branches     4458     4480      +22     
==========================================
+ Hits        13272    13333      +61     
- Misses       7624     8160     +536     
+ Partials      543       37     -506     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from bck-1448-page-types-layout to main February 14, 2025 15:08
@poulch poulch marked this pull request as ready for review February 14, 2025 15:22
@poulch poulch requested review from a team, andrzejewsky and witoszekdev February 14, 2025 15:22
@poulch poulch added the run pw-e2e Run e2e (basic suite from PR automation) label Feb 14, 2025
@github-actions
Copy link
Contributor

merge-reports: Run #4424

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
235 235 0 0 0 0 0 4m41s

🎉 All tests passed!

Github Test Reporter by CTRF 💚

@poulch poulch merged commit e208b0e into main Feb 17, 2025
18 of 22 checks passed
@poulch poulch deleted the bck-1448-product-types-filers branch February 17, 2025 08:48
witoszekdev pushed a commit that referenced this pull request Feb 18, 2025
* Migrate from tabs to filter presets

* Add changeset

* Update test id

* Fix import in providers and extract getFilterElement with test

* Build flags

* Add new conditional filters

* Add tests

* Add changeset

* Fix type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run pw-e2e Run e2e (basic suite from PR automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants