Alerts for apps with issues or disabled apps in app list#5416
Alerts for apps with issues or disabled apps in app list#5416
Conversation
🦋 Changeset detectedLatest commit: 608a8f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5416 +/- ##
==========================================
+ Coverage 61.88% 62.00% +0.12%
==========================================
Files 1259 1266 +7
Lines 21878 21940 +62
Branches 4339 4351 +12
==========================================
+ Hits 13539 13604 +65
+ Misses 8302 8298 -4
- Partials 37 38 +1 ☔ View full report in Codecov by Sentry. |
Cloud11PL
force-pushed
the
PROD-100-app-list-apps-alert
branch
from
fdc1008 to
e600783
Compare
Cloud11PL
force-pushed
the
PROD-100-app-list-apps-alert
branch
from
5565d78 to
3276d98
Compare
Cloud11PL
added
run pw-e2e
merge-reports: Run #4567
🎉 All tests passed!Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
merge-reports: Run #4579
🎉 All tests passed!Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
| </Tooltip.Trigger> | ||
|
|
||
| <Tooltip.Content align="start" side="bottom"> | ||
| <StopPropagation> |
There was a problem hiding this comment.
question: why do you use StopPropagation ?
There was a problem hiding this comment.
Because the event is transffered to the app list row and when you click on the link inside the tooltip you would get navigated to the app instead of the link.
| const hasFailedAttemptsCheck = (webhook: Webhook) => | ||
| webhook.failedDelivers && webhook.failedDelivers?.edges?.length > 0; |
There was a problem hiding this comment.
| const hasFailedAttemptsCheck = (webhook: Webhook) => | |
| webhook.failedDelivers && webhook.failedDelivers?.edges?.length > 0; | |
| const hasFailedAttemptsCheck = (webhook: Webhook) => webhook?.failedDelivers?.edges?.length > 0; |
There was a problem hiding this comment.
Yes, I know it's makes more sense to do what you have proposed, but it seems like it doesn't work with Dashboard's TS version - it produces a TS error. It works with TS 5.7.2 tho
| const hasFailedAttemptsCheck = (webhook: Webhook) => | ||
| webhook.failedDelivers && webhook.failedDelivers?.edges?.length > 0; | ||
| const hasFailedAttemptsInPendingCheck = (webhook: Webhook) => { | ||
| const preliminaryCheck = webhook.pendingDelivers && webhook.pendingDelivers?.edges?.length > 0; |
There was a problem hiding this comment.
| const preliminaryCheck = webhook.pendingDelivers && webhook.pendingDelivers?.edges?.length > 0; | |
| const preliminaryCheck = webhook?.pendingDelivers?.edges?.length > 0; |
merge-reports: Run #4592
🎉 All tests passed!Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
* show alert if there are failed/pending deliveries * i18n * useMemo and booleans * get latest failed/pending event * check attempts * add feature flag * cr fixes * fix test * filter by thirdparty * hook refactor * add missing test * generate flag * generate flag * add feature flag * cr fixes * generate flag * generate flag * add feature flag * cr fixes * apps list ui change * show icon when app is disabled * app list alerts * row alert * link to app details * show focused and hover * add alert for disabled app * add tests * changeset * fix permission check * sort installed apps * add more tests * fix tests * i18n * hide issues alert behind feature flag * mock use flag in test * fix icon import * fix feature flag usage * fetch more pending deliveries * remove app sorting by issue * fix date formatting * don't fetch webhooks without permissions * cr fixes * fix custom app list query
4 participants
Scope of the change