Skip to content

Handle / in nginx config#5450

Merged
poulch merged 3 commits intomainfrom
bck-1509-fix-nginx-config
Mar 4, 2025
Merged

Handle / in nginx config#5450
poulch merged 3 commits intomainfrom
bck-1509-fix-nginx-config

Conversation

@poulch
Copy link
Contributor

@poulch poulch commented Mar 3, 2025

Scope of the change

@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2025

🦋 Changeset detected

Latest commit: 9d1194c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5450 March 3, 2025 16:24 Destroyed
@codecov
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.35%. Comparing base (56d2f7e) to head (9d1194c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #5450    +/-   ##
========================================
  Coverage   62.35%   62.35%            
========================================
  Files        1271     1271            
  Lines       22100    22100            
  Branches     4639     4391   -248     
========================================
  Hits        13780    13780            
- Misses       7766     8281   +515     
+ Partials      554       39   -515     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poulch poulch marked this pull request as ready for review March 4, 2025 10:22
@poulch poulch requested a review from a team March 4, 2025 10:22
@github-actions github-actions bot temporarily deployed to pr-5450 March 4, 2025 10:24 Destroyed
@poulch poulch added the skip e2e label Mar 4, 2025
@github-actions github-actions bot temporarily deployed to pr-5450 March 4, 2025 12:58 Destroyed
@poulch poulch added run pw-e2e Run e2e (basic suite from PR automation) and removed skip e2e labels Mar 4, 2025
@poulch poulch enabled auto-merge (squash) March 4, 2025 16:17
"saleor-dashboard": patch
---

Nginx config now server index.html to paths that doesnot contains dashboard
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nudge: typo

Suggested change
Nginx config now server index.html to paths that doesnot contains dashboard
Nginx config now serves `index.html` to paths that don't contain `/dashboard`

@poulch poulch merged commit 59341db into main Mar 4, 2025
25 of 29 checks passed
@poulch poulch deleted the bck-1509-fix-nginx-config branch March 4, 2025 16:25
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

merge-reports: Run #4770

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
235 235 0 0 0 0 0 5m6s

🎉 All tests passed!

Github Test Reporter by CTRF 💚

Cloud11PL pushed a commit that referenced this pull request Mar 6, 2025
* Handle / in nginx config

* Add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run pw-e2e Run e2e (basic suite from PR automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants