Skip to content

Adopt old apps to extensions page#5493

Merged
poulch merged 27 commits intomainfrom
prod-151-adapt-old-apps
Mar 20, 2025
Merged

Adopt old apps to extensions page#5493
poulch merged 27 commits intomainfrom
prod-151-adapt-old-apps

Conversation

@poulch
Copy link
Contributor

@poulch poulch commented Mar 19, 2025

We've decided to split our work and installed extensions will be done in the second milestone. Now we used old apps page but without available apps instead of new installed extensions page until we don't finish second milestone.

  • Display old apps without available apps in extensions page
  • Fix all links, all pages in apps should link to extensions list instead of old apps when feature flag is on
  • Add filter extensions by name
apps.mov

@changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2025

⚠️ No Changeset found

Latest commit: 6af1833

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5493 March 19, 2025 20:59 Destroyed
@poulch poulch added the skip changeset Use if your changes doesn't need entry in changelog label Mar 19, 2025
@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.05%. Comparing base (49f10aa) to head (6af1833).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/apps/urls.ts 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5493      +/-   ##
==========================================
+ Coverage   63.04%   63.05%   +0.01%     
==========================================
  Files        1287     1288       +1     
  Lines       22273    22287      +14     
  Branches     4594     4424     -170     
==========================================
+ Hits        14042    14054      +12     
- Misses       7684     8197     +513     
+ Partials      547       36     -511     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot temporarily deployed to pr-5493 March 19, 2025 21:07 Destroyed
@poulch poulch added the run pw-e2e Run e2e (basic suite from PR automation) label Mar 20, 2025
@github-actions
Copy link
Contributor

merge-reports: Run #4998

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
235 235 0 0 0 0 0 5m20s

🎉 All tests passed!

Github Test Reporter by CTRF 💚

@poulch poulch marked this pull request as ready for review March 20, 2025 08:45
@poulch poulch requested a review from a team March 20, 2025 08:45
@poulch poulch merged commit f21b4f5 into main Mar 20, 2025
23 of 24 checks passed
@poulch poulch deleted the prod-151-adapt-old-apps branch March 20, 2025 09:40
Cloud11PL pushed a commit that referenced this pull request Mar 20, 2025
* Prepare flag

* Prepare base routing

* Show extensions section in sidebar under ff

* Block extensions routes

* Add changeset

* Add extensions header

* Add search input

* Base list

* Extension card mvp

* Installed badge

* Refactor ExtensionItem and add tests

* Add plugin icon, write test

* Add changeset

* Extract messages

* Add plugin warning

* Add link to request extension

* Update .changeset/great-apes-type.md

Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com>

* Use alias for assets

* Show installed apps list on Extenstions page, use old header for explore page

* Update apps link when ff on

* Add install link

* Add filter by name and empty results

* extract messages

* Remove changeset

---------

Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run pw-e2e Run e2e (basic suite from PR automation) skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants