Search for product variants by SKU in quick search, show media#5495
Merged
Search for product variants by SKU in quick search, show media#5495
Conversation
🦋 Changeset detectedLatest commit: 66a60ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5495 +/- ##
==========================================
+ Coverage 63.14% 63.15% +0.01%
==========================================
Files 1290 1292 +2
Lines 22329 22368 +39
Branches 4614 4610 -4
==========================================
+ Hits 14099 14127 +28
- Misses 7683 8205 +522
+ Partials 547 36 -511 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Differences Found✅ No packages or licenses were added. SummaryExpand
|
Contributor
merge-reports: Run #5091
🎉 All tests passed!Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
witoszekdev
previously approved these changes
Mar 21, 2025
Comment on lines
108
to
111
| variant: { | ||
| defaultMessage: "Variant", | ||
| id: "OK5+Fh", | ||
| }, |
Member
There was a problem hiding this comment.
nitpick: I think we might have string "Variant" somewhere else for translations, so maybe we can re-use it here?
poulch
previously approved these changes
Mar 25, 2025
| display="flex" | ||
| alignItems="center" | ||
| justifyContent="center" | ||
| __padding="2px" |
Contributor
There was a problem hiding this comment.
Suggested change
| __padding="2px" | |
| padding={0.5} |
|
|
||
| import { searchInCatalog } from "./catalog"; | ||
|
|
||
| describe("searchInCatalog", () => { |
Contributor
There was a problem hiding this comment.
Suggested change
| describe("searchInCatalog", () => { | |
| describe("NavigatorSearch / modes / searchInCatalog", () => { |
Comment on lines
7
to
9
| const intl = { | ||
| formatMessage: ({ defaultMessage }) => defaultMessage, | ||
| } as IntlShape; |
poulch
approved these changes
Mar 25, 2025
poulch
added a commit
that referenced
this pull request
Mar 27, 2025
* add variant search by SKU * show media if available * changeset + json messages * add test * cleanup * add loading state to thumbnails * small UI changes * properly hide sku * handle label as react node * fix type issues * i18n * Add missing commments * restore original cmd * add description to messages * cr fixes --------- Co-authored-by: Paweł Chyła <chyla1988@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of the change
Normal search:
Query is SKU:
