Skip to content

Comments

Add "Overcharged" status to orders#5505

Merged
Cloud11PL merged 14 commits intomainfrom
BCK-1407-overcharged-status
Mar 27, 2025
Merged

Add "Overcharged" status to orders#5505
Cloud11PL merged 14 commits intomainfrom
BCK-1407-overcharged-status

Conversation

@Cloud11PL
Copy link
Contributor

@Cloud11PL Cloud11PL commented Mar 24, 2025

Scope of the change

  • Adds chargeStatus to order queries
  • Shows "Overcharged" warning pill with higher priority (if overcharged, payment status will not be shown)
  • Fixes customer orders query - now recent orders list have recent orders

Orders list:
CleanShot 2025-03-24 at 15 43 14

Order details:
CleanShot 2025-03-24 at 15 43 36

Customer details view:
CleanShot 2025-03-24 at 15 41 58

Demo:

CleanShot.2025-03-26.at.11.57.10.mp4

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2025

🦋 Changeset detected

Latest commit: c3e47f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.23%. Comparing base (4d5365d) to head (c3e47f7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/misc.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5505      +/-   ##
==========================================
+ Coverage   63.14%   63.23%   +0.08%     
==========================================
  Files        1292     1293       +1     
  Lines       22371    22387      +16     
  Branches     4611     4635      +24     
==========================================
+ Hits        14127    14157      +30     
+ Misses       8208     7681     -527     
- Partials       36      549     +513     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot temporarily deployed to pr-5505 March 24, 2025 14:46 Destroyed
@Cloud11PL Cloud11PL added the run pw-e2e Run e2e (basic suite from PR automation) label Mar 24, 2025
@github-actions github-actions bot temporarily deployed to pr-5505 March 24, 2025 16:08 Destroyed
@Cloud11PL Cloud11PL marked this pull request as ready for review March 24, 2025 16:21
@Cloud11PL Cloud11PL requested a review from a team March 24, 2025 16:21
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025

merge-reports: Run #5108

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
235 235 0 0 0 0 0 5m11s

🎉 All tests passed!

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@github-actions github-actions bot temporarily deployed to pr-5505 March 25, 2025 09:24 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5505 March 26, 2025 11:09 Destroyed
});
});

type RowDataType = RelayToFlat<NonNullable<OrderListQuery["orders"]>>[number];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: I meant to keep this in one place types.ts and use everywhere

@github-actions github-actions bot temporarily deployed to pr-5505 March 26, 2025 19:59 Destroyed
poulch
poulch previously approved these changes Mar 26, 2025
Co-authored-by: Paweł Chyła <chyla1988@gmail.com>
@Cloud11PL Cloud11PL merged commit 213b9cc into main Mar 27, 2025
17 checks passed
@Cloud11PL Cloud11PL deleted the BCK-1407-overcharged-status branch March 27, 2025 08:13
poulch added a commit that referenced this pull request Mar 27, 2025
* remove deprecated 'token' from orders

* order details overcharge warning

* show overcharged status in order list

* show overcharged status in customer order list

* i18n

* changeset

* update fixutes

* tests & improvements

* add cr fixes

* i18n

* Update .changeset/little-pandas-travel.md

Co-authored-by: Paweł Chyła <chyla1988@gmail.com>

---------

Co-authored-by: Paweł Chyła <chyla1988@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run pw-e2e Run e2e (basic suite from PR automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants