Skip to content

Comments

Extensions install buttons permission check#5506

Merged
poulch merged 4 commits intomainfrom
prod-162-install-button-tooltips
Mar 25, 2025
Merged

Extensions install buttons permission check#5506
poulch merged 4 commits intomainfrom
prod-162-install-button-tooltips

Conversation

@poulch
Copy link
Contributor

@poulch poulch commented Mar 24, 2025

Scope of the change

Add check to install button same as was in apps:

  1. Has no permission to show the disabled button with the tooltip
  2. Is no cloud instance show a disabled button with tooltip
  3. Otherwise show the install button

Add request extensions on explore page

@poulch poulch requested a review from a team March 24, 2025 14:49
@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2025

⚠️ No Changeset found

Latest commit: 37b41ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.13%. Comparing base (17b877f) to head (37b41ab).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nents/ExtenionItem/components/AppInstallButton.tsx 83.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5506      +/-   ##
==========================================
+ Coverage   63.10%   63.13%   +0.03%     
==========================================
  Files        1289     1290       +1     
  Lines       22312    22330      +18     
  Branches     4436     4437       +1     
==========================================
+ Hits        14080    14099      +19     
+ Misses       8196     8195       -1     
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@poulch poulch added skip changeset Use if your changes doesn't need entry in changelog run e2e run pw-e2e Run e2e (basic suite from PR automation) and removed run e2e labels Mar 24, 2025
@github-actions github-actions bot temporarily deployed to pr-5506 March 24, 2025 14:52 Destroyed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025

merge-reports: Run #5080

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
235 235 0 0 0 0 0 4m57s

🎉 All tests passed!

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

Cloud11PL
Cloud11PL previously approved these changes Mar 25, 2025
@poulch poulch merged commit e298bd4 into main Mar 25, 2025
18 checks passed
@poulch poulch deleted the prod-162-install-button-tooltips branch March 25, 2025 09:17
poulch added a commit that referenced this pull request Mar 27, 2025
* Add install buttons permission check

* Update test

* Request extensions on explore page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run pw-e2e Run e2e (basic suite from PR automation) skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants