Skip to content

Add new navigation for Installed Extensions page#5571

Merged
witoszekdev merged 6 commits intomainfrom
prod-200-show-new-links-dev-feature-flag
May 9, 2025
Merged

Add new navigation for Installed Extensions page#5571
witoszekdev merged 6 commits intomainfrom
prod-200-show-new-links-dev-feature-flag

Conversation

@witoszekdev
Copy link
Member

@witoszekdev witoszekdev commented Apr 30, 2025

Scope of the change

Added new navigation for Installed Extensions page with "Add Extension" button that opens a dropdown:

CleanShot 2025-04-30 at 17 41 12@2x

Tip

This change is behind a dev feature flag. Enable it with:

localStorage.setItem('FF_extensions_dev', '{"enabled":true,"payload":"default"}')

@witoszekdev witoszekdev requested a review from a team April 30, 2025 15:41
@changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2025

⚠️ No Changeset found

Latest commit: 6afa655

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@witoszekdev witoszekdev added skip changeset Use if your changes doesn't need entry in changelog run e2e labels Apr 30, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new navigation component for the Installed Extensions page, aiming to consolidate extension-related actions into a single dropdown button.

  • Added the AddExtensionDropdown component with a multi-option dropdown for extension actions.
  • Updated InstalledExtensions view to use the new AddExtensionDropdown instead of rendering separate RequestExtensionsButton and InstallWithManifestFormButton.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/extensions/views/InstalledExtensions/components/AddExtensionDropdown/index.ts Re-exports the main component.
src/extensions/views/InstalledExtensions/components/AddExtensionDropdown/AddExtensionDropdown.tsx Implements a dropdown navigation with options for exploring and installing extensions, including a fallback to the previous navigation if the feature flag is not enabled.
src/extensions/views/InstalledExtensions/InstalledExtensions.tsx Updates the top navigation to conditionally render the new dropdown component.
Comments suppressed due to low confidence (1)

src/extensions/views/InstalledExtensions/InstalledExtensions.tsx:62

  • The AddExtensionDropdown component is now rendered only when hasManagedAppsPermission is true, which may inadvertently hide the RequestExtensionsButton for users without managed apps permission. Please verify that this conditional rendering matches the intended design and user experience.
{hasManagedAppsPermission && <AddExtensionDropdown />}

@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.10%. Comparing base (f2a4105) to head (6afa655).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5571   +/-   ##
=======================================
  Coverage   64.10%   64.10%           
=======================================
  Files        1386     1386           
  Lines       23909    23909           
  Branches     4743     4743           
=======================================
  Hits        15326    15326           
  Misses       8546     8546           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@witoszekdev witoszekdev added run pw-e2e Run e2e (basic suite from PR automation) and removed run e2e labels May 7, 2025
@github-actions github-actions bot temporarily deployed to pr-5571 May 7, 2025 11:06 Destroyed
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

merge-reports: Run #5523

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
247 247 0 0 0 0 0 5m43s

🎉 All tests passed!

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@github-actions github-actions bot temporarily deployed to pr-5571 May 7, 2025 15:54 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5571 May 8, 2025 11:17 Destroyed
@witoszekdev witoszekdev merged commit 6df91ff into main May 9, 2025
18 checks passed
@witoszekdev witoszekdev deleted the prod-200-show-new-links-dev-feature-flag branch May 9, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run pw-e2e Run e2e (basic suite from PR automation) skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants