Add new navigation for Installed Extensions page#5571
Conversation
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new navigation component for the Installed Extensions page, aiming to consolidate extension-related actions into a single dropdown button.
- Added the AddExtensionDropdown component with a multi-option dropdown for extension actions.
- Updated InstalledExtensions view to use the new AddExtensionDropdown instead of rendering separate RequestExtensionsButton and InstallWithManifestFormButton.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/extensions/views/InstalledExtensions/components/AddExtensionDropdown/index.ts | Re-exports the main component. |
| src/extensions/views/InstalledExtensions/components/AddExtensionDropdown/AddExtensionDropdown.tsx | Implements a dropdown navigation with options for exploring and installing extensions, including a fallback to the previous navigation if the feature flag is not enabled. |
| src/extensions/views/InstalledExtensions/InstalledExtensions.tsx | Updates the top navigation to conditionally render the new dropdown component. |
Comments suppressed due to low confidence (1)
src/extensions/views/InstalledExtensions/InstalledExtensions.tsx:62
- The AddExtensionDropdown component is now rendered only when hasManagedAppsPermission is true, which may inadvertently hide the RequestExtensionsButton for users without managed apps permission. Please verify that this conditional rendering matches the intended design and user experience.
{hasManagedAppsPermission && <AddExtensionDropdown />}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5571 +/- ##
=======================================
Coverage 64.10% 64.10%
=======================================
Files 1386 1386
Lines 23909 23909
Branches 4743 4743
=======================================
Hits 15326 15326
Misses 8546 8546
Partials 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
merge-reports: Run #5523
🎉 All tests passed!Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
Scope of the change
Added new navigation for Installed Extensions page with "Add Extension" button that opens a dropdown:
Tip
This change is behind a dev feature flag. Enable it with: