Update ESLint to v9 and TypeScript to latest#5739
Merged
lkostrowski merged 35 commits intomainfrom Aug 6, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 6849202 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Differences FoundExpandLicense Package Apache-2.0 @eslint/config-array Apache-2.0 @eslint/config-helpers Apache-2.0 @eslint/core Apache-2.0 @eslint/object-schema Apache-2.0 @eslint/plugin-kit Apache-2.0 @humanfs/core Apache-2.0 @humanfs/node Apache-2.0 @humanwhocodes/retry Apache-2.0 @pollyjs/adapter Apache-2.0 @pollyjs/core Apache-2.0 @pollyjs/persister Apache-2.0 @pollyjs/utils Apache-2.0 web-vitals BSD-3-Clause @sentry/cli-win32-arm64 ISC walk-up-path MIT @babel/helper-globals MIT @babel/plugin-syntax-class-static-block MIT @babel/plugin-syntax-import-attributes MIT @babel/plugin-syntax-private-property-in-object MIT @codexteam/icons MIT @editorjs/dom MIT @editorjs/helpers MIT @emnapi/core MIT @emnapi/runtime MIT @emnapi/wasi-threads MIT @esbuild/openharmony-arm64 MIT @jest/pattern MIT @napi-rs/wasm-runtime MIT @oxc-resolver/binding-android-arm-eabi MIT @oxc-resolver/binding-android-arm64 MIT @oxc-resolver/binding-darwin-arm64 MIT @oxc-resolver/binding-darwin-x64 MIT @oxc-resolver/binding-freebsd-x64 MIT @oxc-resolver/binding-linux-arm-gnueabihf MIT @oxc-resolver/binding-linux-arm-musleabihf MIT @oxc-resolver/binding-linux-arm64-gnu MIT @oxc-resolver/binding-linux-arm64-musl MIT @oxc-resolver/binding-linux-ppc64-gnu MIT @oxc-resolver/binding-linux-riscv64-gnu MIT @oxc-resolver/binding-linux-riscv64-musl MIT @oxc-resolver/binding-linux-s390x-gnu MIT @oxc-resolver/binding-linux-x64-gnu MIT @oxc-resolver/binding-linux-x64-musl MIT @oxc-resolver/binding-wasm32-wasi MIT @oxc-resolver/binding-win32-arm64-msvc MIT @oxc-resolver/binding-win32-ia32-msvc MIT @oxc-resolver/binding-win32-x64-msvc MIT @radix-ui/react-use-effect-event MIT @rolldown/pluginutils MIT @rollup/rollup-linux-ppc64-gnu MIT @rollup/rollup-linux-riscv64-musl MIT @rtsao/scc MIT @sindresorhus/fnv1a MIT @tybys/wasm-util MIT @types/codemirror MIT @types/set-cookie-parser MIT @types/tern MIT @typescript-eslint/parser MIT @typescript-eslint/project-service MIT @typescript-eslint/tsconfig-utils MIT @typescript-eslint/typescript-estree MIT @wry/caches MIT array-buffer-byte-length MIT array.prototype.findlast MIT array.prototype.findlastindex MIT arraybuffer.prototype.slice MIT async-function MIT blueimp-md5 MIT bowser MIT call-bind-apply-helpers MIT call-bound MIT data-view-buffer MIT data-view-byte-length MIT data-view-byte-offset MIT debounce-promise MIT define-data-property MIT dunder-proto MIT emoji-regex-xs MIT es-define-property MIT es-errors MIT es-iterator-helpers MIT es-object-atoms MIT es-set-tostringtag MIT fd-package-json MIT formatly MIT get-proto MIT globalthis MIT gopd MIT has-proto MIT hasown MIT is-absolute-url MIT is-array-buffer MIT is-async-function MIT is-data-view MIT is-finalizationregistry MIT is-generator-function MIT iterator.prototype MIT json-buffer MIT keyv MIT loglevel MIT math-intrinsics MIT napi-postinstall MIT object.groupby MIT own-keys MIT oxc-resolver MIT possible-typed-array-names MIT quansync MIT reflect.getprototypeof MIT rehackt MIT route-recognizer MIT safe-array-concat MIT safe-push-apply MIT set-cookie-parser MIT set-function-length MIT set-function-name MIT set-proto MIT side-channel-list MIT side-channel-map MIT side-channel-weakmap MIT stop-iteration-iterator MIT string.prototype.repeat MIT string.prototype.trim MIT supports-preserve-symlinks-flag MIT ts-api-utils MIT typed-array-buffer MIT typed-array-byte-length MIT typed-array-byte-offset MIT typed-array-length MIT typescript-eslint MIT undici-types MIT utf8-byte-length MIT which-builtin-type SEE LICENSE IN LICENSE posthog-js SEE LICENSE IN LICENSE spawndamnit WTFPL utf8-byte-length SummaryExpand
|
- Auto-fixed import sorting across all files - Fixed formatting issues automatically corrected by ESLint - Includes initial TypeScript error fixes in test files
- Fix unreachable nullish coalescing operators in OrderPayment component - Fix unnecessary filter in OrderTransaction CardTitle component - Fix nullish coalescing in PermissionGroupDetailsPage and StaffList filters - Fix optional maxDecimalLength usage in PriceField component - All TypeScript checks now passing for both src and playwright
- Install eslint-import-resolver-typescript to resolve module resolution issues - Configure import resolver settings for both TypeScript and Node.js - Re-enable import/no-duplicates rule - Document Storybook plugin as disabled (no Storybook files in project) - Import plugin now working correctly with ESLint 9 flat config
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5739 +/- ##
==========================================
- Coverage 66.40% 66.38% -0.02%
==========================================
Files 1458 1456 -2
Lines 25399 25403 +4
Branches 5195 5224 +29
==========================================
- Hits 16865 16864 -1
+ Misses 8488 7969 -519
- Partials 46 570 +524 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Resolved merge conflicts and integrated latest changes from main branch: - Removed old .eslintrc.json that came back from main - Fixed nullish coalescing in useEnrichConditions.ts - Updated PermissionGroupDetailsPage.tsx with correct hasAllChannels logic - Regenerated package-lock.json to resolve dependency conflicts - Fixed critical ESLint errors (unused expressions in playwright and AppWidgets) - Added ESLint rule overrides for legacy code compatibility All merge conflicts resolved, ESLint configuration updated for compatibility.
- Removed invalid @typescript-eslint/key-spacing eslint-disable comment - Converted require() imports to ES modules in test file - Fixed duplicate Jest mocks declarations - Updated import resolver to use only TypeScript resolver - Installed missing resolve dependency ESLint now runs clean with 0 errors, only warnings remain. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
witoszekdev
force-pushed
the
update-eslint-flatconfig
branch
from
6ff16e1 to
e64892e
Compare
Member
Author
|
@lkostrowski I've checked rules again and there in fact were some of them missing either due to my mistake or because I used different set of recommended rules 😅 |
kzuraw
previously approved these changes
Aug 6, 2025
lkostrowski
previously approved these changes
Aug 6, 2025
* Update MacawUI to 1.3.0 * use 1.3.1
* refactor: improve UnderlineLink component API and structure
- Extract UnderlineText component for better separation of concerns
- Change UnderlineLink to extend anchor attributes instead of TextProps
- Add textProps parameter for customizing text styling
- Set default size={2} in UnderlineText component
- Remove redundant size props from component usage
* fixes after cr
kzuraw
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates Dashboard to use ESLint v9 which uses flat config and fixes reported errors after that migration (that's the cause of large file count change). It also updates TypeScript to latest version - this had to be done to resolve issues with TypeScript ESLint plugin.
Most of changes in files are stylistic or to fix TypeScript errors and don't impact any logic. For logic changes there were comments from me (see below).
Note
For some reason depcruise detected a change in:
Which is incorrect, this file was not changed. That's why macaw migration check is failing
Note
There are more warnings now due to recommended changes in Code Review. All of existing warnings still exists (checked using diff), due to plugin updates there were also new error messages added in the same files or some were changed.
It also fixes some other setup related issues that become apparent after this migration:
^)./* eslint-disable */comment, since they were removed from ESLint checks by using global config