Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5755 +/- ##
==========================================
+ Coverage 66.35% 66.37% +0.01%
==========================================
Files 1456 1457 +1
Lines 25366 25381 +15
Branches 5004 5204 +200
==========================================
+ Hits 16832 16847 +15
+ Misses 8488 7965 -523
- Partials 46 569 +523 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| onSubmit={handleSubmit} | ||
| /> | ||
| )} | ||
| <GiftCardBulkCreateDialogForm |
There was a problem hiding this comment.
shouldnt it incldue prop loading={loadingChannelCurrencies}?
There was a problem hiding this comment.
Nope - it turns out loading was only for GiftCardCreateMoneyInput - now this component has loading inside.
| * This helps avoid unnecessary network requests when the channel currencies data is already available. | ||
| */ | ||
| export function useChannelCurrenciesWithCache() { | ||
| const client = useApolloClient(); |
There was a problem hiding this comment.
why this is not cached with apollo? I mean we can't create a wrapper for every object and appollo supports that
There was a problem hiding this comment.
TBH I don't know but if I didn't used custom hook useChannelQuery gets triggered - maybe we should use useQuery instead of custom generated hooks?
* Fix bulk gift card re-rendering * Add changeset
2 participants
Scope of the change
This PR fixes gift card modal re-rendering issues. I also removed
@ts-ignore, barrel file and default export.Modal:
