Skip to content

Run lint-staged on files in root directory#5867

Merged
witoszekdev merged 7 commits intomainfrom
fix-lint-staged
Sep 22, 2025
Merged

Run lint-staged on files in root directory#5867
witoszekdev merged 7 commits intomainfrom
fix-lint-staged

Conversation

@witoszekdev
Copy link
Member

This PR fixes an issue where lint-staged wouldn't run on files in root directory (e.g. eslint.config.js)

@witoszekdev witoszekdev requested a review from a team as a code owner September 16, 2025 17:33
@witoszekdev witoszekdev requested review from Copilot, kzuraw and lkostrowski and removed request for Copilot September 16, 2025 17:33
@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2025

⚠️ No Changeset found

Latest commit: 040949f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
saleor-dashboard-storybook Ready Ready Preview Comment Sep 22, 2025 7:24am

@witoszekdev witoszekdev added the skip changeset Use if your changes doesn't need entry in changelog label Sep 16, 2025
@github-actions github-actions bot temporarily deployed to pr-5867 September 16, 2025 17:36 Destroyed
@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.64%. Comparing base (cee2ff1) to head (040949f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #5867     +/-   ##
=========================================
  Coverage   38.64%   38.64%             
=========================================
  Files        2742     2742             
  Lines       43228    43228             
  Branches     9801     9801             
=========================================
  Hits        16707    16707             
- Misses      25209    26491   +1282     
+ Partials     1312       30   -1282     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI review requested due to automatic review settings September 16, 2025 17:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses an issue where lint-staged wasn't processing files in the root directory by switching from .js to .cjs configuration format and adding explicit patterns for root-level JavaScript files.

  • Renamed lint-staged.config.js to lint-staged.config.cjs with CommonJS module syntax
  • Added pattern to include root directory JavaScript files in lint-staged processing
  • Updated ESLint configuration to properly handle .cjs files with Node.js globals

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
lint-staged.config.js Removed original JavaScript configuration file
lint-staged.config.cjs Added new CommonJS configuration with root directory pattern
eslint.config.mjs Added Node.js globals configuration for .cjs files and improved message formatting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot temporarily deployed to pr-5867 September 16, 2025 17:46 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5867 September 17, 2025 10:08 Destroyed
Copilot AI review requested due to automatic review settings September 17, 2025 14:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot temporarily deployed to pr-5867 September 17, 2025 14:17 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5867 September 17, 2025 14:58 Destroyed
@witoszekdev witoszekdev enabled auto-merge (squash) September 17, 2025 15:35
Copilot AI review requested due to automatic review settings September 18, 2025 09:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot temporarily deployed to pr-5867 September 18, 2025 09:14 Destroyed
@witoszekdev witoszekdev merged commit 9af22c3 into main Sep 22, 2025
18 checks passed
@witoszekdev witoszekdev deleted the fix-lint-staged branch September 22, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants