Skip to content

better copy for app uninstall message#5878

Merged
lkostrowski merged 2 commits intomainfrom
better-app-uninstall-copy
Sep 22, 2025
Merged

better copy for app uninstall message#5878
lkostrowski merged 2 commits intomainfrom
better-app-uninstall-copy

Conversation

@lkostrowski
Copy link
Member

@lkostrowski lkostrowski commented Sep 18, 2025

changed copy to what is actually a truth

Copilot AI review requested due to automatic review settings September 18, 2025 08:39
@lkostrowski lkostrowski requested a review from a team as a code owner September 18, 2025 08:39
@vercel
Copy link

vercel bot commented Sep 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
saleor-dashboard-storybook Ready Ready Preview Comment Sep 22, 2025 6:56am

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2025

⚠️ No Changeset found

Latest commit: 2fb14bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the message text for the app uninstall warning to improve clarity and accuracy. The change replaces the reference to "customer's personal data" with the more accurate term "metadata" to better reflect what is actually being removed during uninstallation.

  • Updated app uninstall warning message to use "metadata" instead of "customer's personal data"
  • Updated corresponding message ID and translation file entries

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/extensions/messages.ts Updated the default message text and ID for the app uninstall warning
locale/defaultMessages.json Added new translation entry and removed the old one

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lkostrowski lkostrowski added the skip changeset Use if your changes doesn't need entry in changelog label Sep 18, 2025
@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.64%. Comparing base (543984e) to head (2fb14bc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #5878     +/-   ##
=========================================
  Coverage   38.64%   38.64%             
=========================================
  Files        2745     2745             
  Lines       43254    43254             
  Branches     9455     9807    +352     
=========================================
  Hits        16714    16714             
+ Misses      26510    25227   -1283     
- Partials       30     1313   +1283     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot temporarily deployed to pr-5878 September 18, 2025 08:43 Destroyed
@lkostrowski lkostrowski enabled auto-merge (squash) September 22, 2025 06:54
@lkostrowski lkostrowski merged commit a2c1987 into main Sep 22, 2025
16 checks passed
@lkostrowski lkostrowski deleted the better-app-uninstall-copy branch September 22, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants