Conversation
🦋 Changeset detectedLatest commit: 802c21e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes the app_alerts feature flag, making webhook issue alerts in the dashboard permanently enabled. This simplifies the codebase by eliminating conditional rendering based on the feature flag.
- Removes all references to the
app_alertsfeature flag from components and hooks - Makes app alert components always visible in the sidebar and app list views
- Updates the build script file extension and cleans up generated feature flag files
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/components/Sidebar/menu/hooks/useMenuStructure.tsx | Removes feature flag checks and always renders SidebarAppAlert components |
| src/apps/views/AppListView/AppListView.tsx | Removes feature flag import and condition, always enables app event fetching |
| src/apps/components/InstalledAppListRow/InstalledAppListRow.tsx | Removes conditional rendering and always shows app alerts |
| src/apps/components/AppAlerts/useAppsAlert.ts | Removes the enabled parameter from the hook |
| package.json | Updates build-flags script file extension |
| .featureFlags/generated.tsx | Removes app_alerts flag definition and updates image imports |
| .featureFlags/app_alerts.md | Deletes the feature flag documentation file |
| .changeset/plenty-falcons-yawn.md | Adds changelog entry for the feature flag removal |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| {hasAppAlertsFeatureFlag && ( | ||
| <SidebarAppAlert hasNewFailedAttempts={hasNewFailedAttempts} small /> | ||
| )} | ||
| {<SidebarAppAlert hasNewFailedAttempts={hasNewFailedAttempts} small />} |
There was a problem hiding this comment.
[nitpick] Unnecessary braces around JSX expression. Remove the braces for cleaner code: <SidebarAppAlert hasNewFailedAttempts={hasNewFailedAttempts} small />
| {<SidebarAppAlert hasNewFailedAttempts={hasNewFailedAttempts} small />} | |
| <SidebarAppAlert hasNewFailedAttempts={hasNewFailedAttempts} small /> |
Differences Found✅ No packages or licenses were added. SummaryExpand
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5879 +/- ##
========================================
Coverage 38.64% 38.64%
========================================
Files 2745 2745
Lines 43254 43237 -17
Branches 9455 9794 +339
========================================
- Hits 16714 16708 -6
+ Misses 26510 26499 -11
Partials 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
src/apps/components/InstalledAppListRow/InstalledAppListRow.tsx:1
- The JSX expression
{<SidebarAppAlert hasNewFailedAttempts={hasNewFailedAttempts} small />}has unnecessary curly braces. Since this is always rendered now, it should be simplified to<SidebarAppAlert hasNewFailedAttempts={hasNewFailedAttempts} small />.
import { appsMessages } from "@dashboard/apps/messages";
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@witoszekdev @krzysztofzuraw closing this PR because entire apps/ dir should be removed soon. The remaining flag usage in navbar I can clean up after we remove this apps/ |
After this change, alerts displaying webhook issues near apps will be always available (which is now) - without a way to revert